fix: adjust cache-control handling for [email protected] #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
added
the
test all versions
📊 Package size report 0%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
force-pushed
the
michalpiechowiak/frb-1385-next1500-canary187-produces-invalid-cache-control-somtimes
branch
from
2973a63
to
93dd2b6
Compare
pieh
commented
Oct 14, 2024
| return header | ||
| .split(',') | ||
| .map((value) => value.trim()) | ||
| .filter(Boolean) |
There was a problem hiding this comment.
https://github.com/vercel/next.js/pull/71159/files#diff-ae41ee59d88093c9c0551e12f654b1b99e4211b1c9fa6dc1471febb0361004e7R21 this can now produce invalid value like s-maxage=31536000, so we remove ~falsy/empty directives, so at least on our end we produce valid value.
Hopefully they fix their stuff in which this added .filter would do nothing (so it also won't hurt to have it always)
orinokai
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
this looks fine to me - the tests could be simplified by only checking for the max-age and durable directives without having the next version check (since even if the stale-while-revalidate header was missing in the previous version it's kind of redundant anyway), but it doesn't hurt to be explicit so lgtm
…-produces-invalid-cache-control-somtimes
…-produces-invalid-cache-control-somtimes
pieh
deleted the
michalpiechowiak/frb-1385-next1500-canary187-produces-invalid-cache-control-somtimes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
vercel/next.js#71159 (comment) this changes the way
stale-while-revalidateis generated - instead of always being whatever is set toswrDelta/expireTime- it now is this value subtracted byrevalidatetime - if bothrevalidateandexpireTimeis the same - then cache-control no longer hasstale-while-revalidateat all (this will be the case for example forgetStaticPropspages withoutrevalidatespecified)Documentation
Tests
Tests were adjusted (or skipped if they didn't make any sense anymore - like one that checks if
stale-while-revalidateis parameterized or notRelevant links (GitHub issues, etc.) or a picture of cute animal
https://linear.app/netlify/issue/FRB-1385/next1500-canary187-produces-invalid-cache-control-somtimes