Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct protocol for image source #467

Merged
merged 2 commits into from
Jul 1, 2021
Merged

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Jun 30, 2021

Ensure that sources images are loaded using the same protocol as the original request. When redirecting unsupported images (svg, gif), use a relative path in the redirect to ensure protocols match.

Fixes #466

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Jun 30, 2021
@ascorbic ascorbic force-pushed the fix/redirect-protocol branch 3 times, most recently from 03e8b67 to cee4182 Compare July 1, 2021 06:08
@ascorbic ascorbic marked this pull request as ready for review July 1, 2021 07:12
@ascorbic ascorbic merged commit 4edbc73 into main Jul 1, 2021
@ascorbic ascorbic deleted the fix/redirect-protocol branch July 1, 2021 10:29
serhalp pushed a commit that referenced this pull request Jun 13, 2024
* chore: move systemlog to a cts file

* fix: leverage system logger in place of console
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mixed Content Warning Error on SVG Images in Next 11
2 participants