New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MatchesMonitorScopeSelector helper function checks only one field #164

Closed

glazychev-art opened this issue Aug 2, 2023 · 1 comment

Assignees

Labels

bug

Contributor

glazychev-art commented Aug 2, 2023

Description

MatchesMonitorScopeSelector function takes into account only PathSegment.Name - https://github.com/networkservicemesh/api/blob/main/pkg/api/networkservice/connection_helpers.go#L150

This is wrong, because there are other fields in the PathSegment - at least we use connection ID in some places:
https://github.com/networkservicemesh/sdk/blob/main/pkg/networkservice/common/heal/eventloop.go#L60-L65
https://github.com/networkservicemesh/cmd-nsc/blob/main/main.go#L253-L256

glazychev-art added this to Release v1.11.0

glazychev-art added the bug label

denis-tingaikin assigned NikitaSkrynnik

NikitaSkrynnik moved this to In Progress in Release v1.11.0

NikitaSkrynnik mentioned this issue

Fix Connection Selector #165

Merged

Member

denis-tingaikin commented Sep 25, 2023

Seems like done.

@glazychev-art , @NikitaSkrynnik Thanks!

denis-tingaikin closed this as completed

github-project-automation bot moved this from In Progress to Done in Release v1.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment