Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dual stack support #261

Closed
glazychev-art opened this issue Dec 8, 2023 · 3 comments
Closed

Add dual stack support #261

glazychev-art opened this issue Dec 8, 2023 · 3 comments
Assignees

Comments

@glazychev-art
Copy link
Contributor

glazychev-art commented Dec 8, 2023

Description

Currently vL3-endpoint only support single stack:
https://github.com/networkservicemesh/cmd-nse-vl3-vpp/blob/main/main.go#L551

It would be useful to add dualStack support.
For example, cmd-nse-icmp-responder already supports it:
https://github.com/networkservicemesh/cmd-nse-icmp-responder/blob/main/main.go#L208

@denis-tingaikin
Copy link
Member

denis-tingaikin commented Jan 9, 2024

The plan for implementing this could be:

  1. deploy two vl3 ipams, one with ipv4 (as in the examples right now), the second with ipv6 prefixes
  2. modify github.com/networkservicemesh/sdk/pkg/networkservice/connectioncontext/ipcontext/vl3 work with an array of prefixes exactly the same as in groupipam
  3. covert this https://github.com/networkservicemesh/cmd-nse-vl3-vpp/blob/main/main.go#L113 to the list
  4. add dualstack vl3 example for deployments-k8s
  5. consider api modification https://github.com/networkservicemesh/api/blob/main/pkg/api/ipam/ipam.proto#L37

@denis-tingaikin denis-tingaikin moved this to In Progress in Release v1.13.0 Jan 10, 2024
@VitalyGushin VitalyGushin moved this from In Progress to Under review in Release v1.13.0 Feb 20, 2024
@VitalyGushin VitalyGushin moved this from Under review to In Progress in Release v1.13.0 Mar 26, 2024
@NikitaSkrynnik NikitaSkrynnik moved this from In Progress to Under review in Release v1.13.0 Mar 27, 2024
@denis-tingaikin denis-tingaikin moved this from Under review to Moved to next release in Release v1.13.0 Apr 9, 2024
@NikitaSkrynnik NikitaSkrynnik moved this to In Progress in Release v1.14.0 Apr 16, 2024
@VitalyGushin
Copy link

VitalyGushin commented Apr 17, 2024

Integration Tests: networkservicemesh/integration-k8s-kind#1006

@VitalyGushin VitalyGushin moved this from In Progress to Under review in Release v1.14.0 Apr 18, 2024
@denis-tingaikin
Copy link
Member

Seems like done.

@edwarnicke FYI: Now we can use dual stack for vl3 networks.

@github-project-automation github-project-automation bot moved this from Under review to Done in Release v1.14.0 Apr 24, 2024
@github-project-automation github-project-automation bot moved this from Moved to next release to Done in Release v1.13.0 Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

No branches or pull requests

3 participants