Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert permutation tests to functions #101

Open
tsalo opened this issue Jun 2, 2022 · 0 comments
Open

Convert permutation tests to functions #101

tsalo opened this issue Jun 2, 2022 · 0 comments
Labels
breaking-change PRs that change results or interfaces. enhancement New feature or request

Comments

@tsalo
Copy link
Member

tsalo commented Jun 2, 2022

MetaRegressionResult.permutation_test and CombinationTestResult.permutation_test both require access to the Result object, which is a bit much for NiMARE Estimators to hold onto between the fitting and correction steps. If we could convert the methods to functions, and possibly distinguish the null distribution creation step from the correction step, I think that could help NiMARE.

This stems from neurostuff/NiMARE#278.

@tsalo tsalo added enhancement New feature or request breaking-change PRs that change results or interfaces. labels Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change PRs that change results or interfaces. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant