wrong message order in [MS-RDPEFS] setup

[akallabeth]

1. Got a report Drive redirection not working in Alt Linux FreeRDP/FreeRDP#9501
2. found

   xrdp/sesman/chansrv/devredir.c

   Line 381 in ee32878

   devredir_send_server_user_logged_on();

3. [MS-RDPEFS] tells that this is the wrong state you´re sending the RDPDR_USER_LOGGEDON_PDU

[matt335672]

Thanks @akallabeth

I'm out of time at the mo', but I'll look later in the week. Your OP appears to have sent all relevant info.

[matt335672]

I can confirm xrdp is not conforming to [MS-RDPEFS], so it's almost certainly an xrdp bug.

It happens with FreeRDP 2.11.2 (Alt Linux 10.1) but not 2.9.0.

By moving the devredir_send_server_user_logged_on() down to after we've received the client core capability response (as the specification) I can get the redirection working again.

That's a quick test. I'm not testing the client has RDPDR_USER_LOGGEDON_PDU set yet. I'll also need to re-test with existing working clients then I can issue a patch.