Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Change PropType of steps.name from string to object #113

Closed
ghost opened this issue Sep 13, 2018 · 1 comment
Closed

Suggestion: Change PropType of steps.name from string to object #113

ghost opened this issue Sep 13, 2018 · 1 comment

Comments

@ghost
Copy link

ghost commented Sep 13, 2018

Hi there,
I want to suggest changing the PropType from String to Object type.
My change request arises because I would like to use FontAwesome components for the navigation steps.
And I think more flexibility is a good think.

const steps =
            [
                {name: <FontAwesomeIcon icon="book-open"/>, component: <Step1/>},
                {name: <FontAwesomeIcon icon="ruler-combined"/>, component: <Step2/>},
                {name: <FontAwesomeIcon icon="tint"/>, component: <Step3/>},
                {name: <FontAwesomeIcon icon="user"/>, component: <Step4/>},
                {name: <FontAwesomeIcon icon="check"/>, component: <Step5/>}
            ];

grafik

@ghost ghost changed the title Suggestion: Change PropType of steps.name from string to object Suggestion: Change PropType of steps.name from string to object and rename it Sep 13, 2018
@ghost ghost changed the title Suggestion: Change PropType of steps.name from string to object and rename it Suggestion: Change PropType of steps.name from string to object Sep 20, 2018
@newbreedofgeek
Copy link
Owner

@tomtoxx thats a very cool looking implementation of StepZilla, I didn't expect FontAwesomeIcon to be used with 'name'

Have you tested it? Does it work for you as intended? Do you see any error in the console? (except for the propTypes error?)

@newbreedofgeek newbreedofgeek added Discussion Useful Tips Waiting for OP Waiting for Original Poster to respond labels Oct 18, 2018
@newbreedofgeek newbreedofgeek removed Discussion Waiting for OP Waiting for Original Poster to respond labels Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant