-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gatsby] Investigate our use of redirectInBrowser #3600
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be automatically closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be automatically closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed because it was a stale issue that had no recent activity. Thank you for your contributions. |
Description
We currently use
redirectInBrowser: true
exclusively in the Docs site, however, Gatsby have let us know that this isn't necessary in the majority of cases. We may need this for certain legacy redirects between docs site pages, but we might not need it for all our redirects.This ticket is to investigate whether we need to use this setting for all our redirects.
Here’s an example. this doc link is old and 404s
https://docs.newrelic.com/docs/alerts/new-relic-alerts/rest-api-alerts
and if you search the repo you see it referenced in 7 files. it was either a chained redirect in Drupal or the content was moved and a redirect was never created for whatever reason.
Another option is that we update those stale links now that the content is in files that we can easily find / replace on. This may allow us to remove the use of
redirectInBrowser: true
completely.Gatsby issue detailing this: gatsbyjs/gatsby#32669
Further discussion: #2139 (comment)
Acceptance Criteria
redirectInBrowser
is necessary or not for our redirectsThe text was updated successfully, but these errors were encountered: