Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about known aspnet instrumentation failure scenarios #2830

Open
nrcventura opened this issue Oct 11, 2024 · 1 comment
Open

Warn about known aspnet instrumentation failure scenarios #2830

nrcventura opened this issue Oct 11, 2024 · 1 comment

Comments

@nrcventura
Copy link
Member

nrcventura commented Oct 11, 2024

Aspnet instrumentation stores its context data (transaction and current segment in HttpContext). Sometimes this context storage can get cleared out, when this happens the agent will lose track of the transaction until it is garbage collected. This results in incorrect timing and missing data from the transaction

Calls to Response.End can trigger the aspnet runtime to return the response immediately and not run anymore steps in the aspnet pipeline. This prevents the final step in the pipeline from running which results in the transaction never ending. This also results in the transaction being lost and eventually being garbage collected. This can result in missing data (such as a missing response status code) and incorrect timing.

We should determine whether its possible to write some instrumentation for these two scenarios to at least be able to log a warning about this happening. If it's possible, we should also consider writing code to better handle these situations.

Estimates

Initial t-shirt size: M

@workato-integration
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant