Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt downloading pre-built first before building #197

Closed
bizob2828 opened this issue Jun 21, 2022 · 1 comment · Fixed by #230
Closed

Attempt downloading pre-built first before building #197

bizob2828 opened this issue Jun 21, 2022 · 1 comment · Fixed by #230
Assignees
@jmartin4563
Labels
feature-request points: 1 1 days or less sync2jira

Comments

@bizob2828
Copy link
Member

Is your feature request related to a problem? Please describe.

We release prebuilt binaries for linux. However when a customer tries to install the agent and subsequently install the native metrics we try to build first. This causes the installation to take longer.

Feature Description

Try downloading prebuilt first before building module.

Additional context

There is an en var that does this for you NR_NATIVE_METRICS_NO_BUILD but that only tries to download. We should just shift the logic for the default case to try downloading before building.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmartin4563 jmartin4563

Labels
feature-request points: 1 1 days or less sync2jira
Projects
Node.js Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: update prebuild to download first, fallback to build jmartin4563/node-native-metrics
3 participants
@coreyarnold @bizob2828 @jmartin4563