Skip to content

Commit

Permalink
fix(test): ensure relevant minor versions of redis and grpc run
Browse files Browse the repository at this point in the history
Our instrumentation changed across these minor versions, so running
versioned tests with a `--minor` flag won't test both sides of the
instrumentation across these minor versions. So explicitly make a
break in the version numbers defined in the tests to ensure that these
different minor version numbers are tested.
  • Loading branch information
Jordi Gutiérrez Hermoso committed Jun 16, 2023
1 parent 75bc832 commit 4f18c23
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 2 deletions.
20 changes: 19 additions & 1 deletion test/versioned/grpc/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,25 @@
"node": ">=14"
},
"dependencies": {
"@grpc/grpc-js": ">=1.4.0"
"@grpc/grpc-js": ">=1.4.0 <1.8.0"
},
"files": [
"client-unary.tap.js",
"client-streaming.tap.js",
"client-server-streaming.tap.js",
"client-bidi-streaming.tap.js",
"server-unary.tap.js",
"server-client-streaming.tap.js",
"server-streaming.tap.js",
"server-bidi-streaming.tap.js"
]
},
{
"engines": {
"node": ">=14"
},
"dependencies": {
"@grpc/grpc-js": ">=1.8.0"
},
"files": [
"client-unary.tap.js",
Expand Down
13 changes: 12 additions & 1 deletion test/versioned/redis/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,18 @@
"node": ">=14"
},
"dependencies": {
"redis": ">=2.0.0 < 4"
"redis": ">=2.0.0 < 2.6.0"
},
"files": [
"redis.tap.js"
]
},
{
"engines": {
"node": ">=14"
},
"dependencies": {
"redis": ">=2.6.0 < 4"
},
"files": [
"redis.tap.js"
Expand Down

0 comments on commit 4f18c23

Please sign in to comment.