From 4f18c2316c609a7267c9d7d21171f3edac81d422 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jordi=20Guti=C3=A9rrez=20Hermoso?= Date: Fri, 16 Jun 2023 09:42:32 -0400 Subject: [PATCH] fix(test): ensure relevant minor versions of redis and grpc run Our instrumentation changed across these minor versions, so running versioned tests with a `--minor` flag won't test both sides of the instrumentation across these minor versions. So explicitly make a break in the version numbers defined in the tests to ensure that these different minor version numbers are tested. --- test/versioned/grpc/package.json | 20 +++++++++++++++++++- test/versioned/redis/package.json | 13 ++++++++++++- 2 files changed, 31 insertions(+), 2 deletions(-) diff --git a/test/versioned/grpc/package.json b/test/versioned/grpc/package.json index 7faa4f5f07..2f42f4b77b 100644 --- a/test/versioned/grpc/package.json +++ b/test/versioned/grpc/package.json @@ -8,7 +8,25 @@ "node": ">=14" }, "dependencies": { - "@grpc/grpc-js": ">=1.4.0" + "@grpc/grpc-js": ">=1.4.0 <1.8.0" + }, + "files": [ + "client-unary.tap.js", + "client-streaming.tap.js", + "client-server-streaming.tap.js", + "client-bidi-streaming.tap.js", + "server-unary.tap.js", + "server-client-streaming.tap.js", + "server-streaming.tap.js", + "server-bidi-streaming.tap.js" + ] + }, + { + "engines": { + "node": ">=14" + }, + "dependencies": { + "@grpc/grpc-js": ">=1.8.0" }, "files": [ "client-unary.tap.js", diff --git a/test/versioned/redis/package.json b/test/versioned/redis/package.json index cbdd6a1444..4f26c76dbb 100644 --- a/test/versioned/redis/package.json +++ b/test/versioned/redis/package.json @@ -8,7 +8,18 @@ "node": ">=14" }, "dependencies": { - "redis": ">=2.0.0 < 4" + "redis": ">=2.0.0 < 2.6.0" + }, + "files": [ + "redis.tap.js" + ] + }, + { + "engines": { + "node": ">=14" + }, + "dependencies": { + "redis": ">=2.6.0 < 4" }, "files": [ "redis.tap.js"