Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of instrumentation and accurate test for mysql poolCluster #1645

Closed
mrickard opened this issue May 19, 2023 · 2 comments · Fixed by #1647
Closed

Lack of instrumentation and accurate test for mysql poolCluster #1645

mrickard opened this issue May 19, 2023 · 2 comments · Fixed by #1647
Assignees
Labels

Comments

@mrickard
Copy link
Member

Description

A customer observed a loss of telemetry for mysql poolCluster. This gap in telemetry was missed in version tests for mysql pooling: these tests used createConnection (invoked in a setup script). Removing this showed that the agent was not creating segments for poolCluster queries.

Expected Behavior

versioned/mysql/basic-pool.tap.js test should pass when using a poolCluster connection, and not rely on instrumentation via createConnection

Steps to Reproduce

See @bizob2828 's changes in https://github.com/newrelic/node-newrelic/tree/mysql-fix

Running versioned tests in that branch will fail subtests in the poolCluster query test. For example, while transactions exist, no segment has been created.

Additional context

See https://issues.newrelic.com/browse/NR-116646

@workato-integration
Copy link

@workato-integration
Copy link

Jira CommentId: 204178
Commented by mrickard:

PR: #1647

Thanks to [~revans] for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
1 participant