Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Node 14 #1725

Closed
bizob2828 opened this issue Jul 13, 2023 · 4 comments · Fixed by #1756
Closed

Drop Node 14 #1725

bizob2828 opened this issue Jul 13, 2023 · 4 comments · Fixed by #1756
Assignees

Comments

@bizob2828
Copy link
Member

Description

As part of supporting Node 20 we need to drop support for Node 14

Acceptance Criteria

  • Update engines
  • Update all versioned stanzas
  • Update initial version check
  • Check todos for node 14 specific stuff
@workato-integration
Copy link

@pjrharley
Copy link

pjrharley commented Aug 4, 2023

Hi - not sure if this was a deliberate choice but this PR has made v10.6.0 incompatible with Node 14 already (it may or may not actually work - but npm install fails when using engine-strict=true.

The problem is that updating to @newrelic/[email protected] has updated the transitive dependency [email protected] which declares it supports node 16 and up: https://github.com/Alex-D/check-disk-space/blob/v3.4.0/package.json#L43

Edit: I just noticed the particular irony in this - the release notes for 10.6.0 say:

restored engines to >=14 until we actually drop support for Node 14 #1738

but in fact due to this issue node 14 is still unsupported.

It would appear this issue has actually been around since the security-agent package was added in 10.3.0, so perhaps you are already aware of it.

@bizob2828
Copy link
Member Author

bizob2828 commented Aug 4, 2023

Hi @pjrharley thanks for bringing this to our attention. A different team maintains the security agent so we were not aware. I logged newrelic/csec-node-agent#74 so you can track the work

@bizob2828
Copy link
Member Author

@pjrharley the fix for security agent relying on a package that doesn't support Node.js 14 has been released in 10.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants