Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make persp-find-some smarter #90

Closed
zenspider opened this issue Sep 4, 2019 · 3 comments
Closed

Make persp-find-some smarter #90

zenspider opened this issue Sep 4, 2019 · 3 comments

Comments

@zenspider
Copy link
Collaborator

I'm not thrilled with the way persp-find-some works when you're killing off perspectives.

The gist: Let's say you're using this mode (persps sorted chronologically) to do a yak shave and you have several perspectives pushed on the stack. You finish up some of them and start to kill the perspectives. The first time, it uses persp-last to switch to the last one you were on. That seems fine. But after that, persp-last is nil and it goes to (car (persp-names)) instead. That doesn't really match the workflow for this mode and should be something a bit smarter (newest, or persp-last should maintain a stack, or something).

Originally posted by @zenspider in #87 (comment)

@gcv
Copy link
Collaborator

gcv commented Sep 4, 2019

I wonder if this might be the excuse needed to stop using frame parameters to store state and switch to a global hash table indexed by frame (id). Frame parameters cause other problems, like the one #86 attempts to address. It's kind of a big change, though.

@gcv
Copy link
Collaborator

gcv commented Jan 28, 2020

Looking at this and thinking about it... doesn't (persp-names) respect the sorting order? I just tried it, and perspective killing proceeded in pop-the-stack order. IOW Perspective currently behaves just like description suggests it should, at least for the yak shave workflow. Maybe I'm missing something?

@gcv
Copy link
Collaborator

gcv commented Jul 19, 2020

Let's reopen if this is still something we need to look at.

@gcv gcv closed this as completed Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants