Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make possible to specify the container for the filepicker dialog #427

Closed
danxuliu opened this issue Aug 25, 2021 · 2 comments · Fixed by #950
Closed

Make possible to specify the container for the filepicker dialog #427

danxuliu opened this issue Aug 25, 2021 · 2 comments · Fixed by #950
Assignees
Labels
bug Something isn't working
Milestone

Comments

@danxuliu
Copy link
Contributor

The dialogs are appended to the body element. However, in some cases the filepicker dialog needs to be appended to a different element (for example, if a sub-element is shown in fullscreen mode, like done in Talk), as otherwise it would not be visible.

This may require to adjust the ocdialogs function in server. Alternatively it might be possible to address this directly in nextcloud-dialogs by reparenting the dialog once it was created, although I have not verified it.

Note that the modal dialog overlay would also need to be reparented to the proper element.

How to test

  • Open a conversation in Talk
  • Switch to full screen mode
  • Try to share a file

Expected result

The file picker dialog is shown.

Actual result

The overlay is shown, but not the file picker dialog.

@ChristophWurst
Copy link
Contributor

Easily done once we have #1 😉

@susnux
Copy link
Contributor

susnux commented Aug 18, 2023

As we now have #1, I plan to implement this for 5.0.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants