Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Upload: uploads 0b files #1295

Closed
tobiasKaminsky opened this issue Aug 10, 2017 · 12 comments · Fixed by #1468
Closed

Auto Upload: uploads 0b files #1295

tobiasKaminsky opened this issue Aug 10, 2017 · 12 comments · Fixed by #1468

Comments

@tobiasKaminsky
Copy link
Member

  • latest LineageOS, OnePlus 3
  • take a picture with camera app OR take a screenshot, both with provided apps by LineageOS
  • see that 0b are uploaded
  • in Amaze (file browser) the file size is also 0b, but it is shown correctly in gallery, however in nextcloud app it is not shown (error image)

Using another camera app (open camera) it is working fine.

@tobiasKaminsky
Copy link
Member Author

Strange, seems more a bug in the camera (snap) app:

  • right after taking an image it is ~2-3Mb, showing in gallery is also fine
  • seconds later, it is 0b and the image is a little bit corrupted on the bottom

@mario
Copy link
Contributor

mario commented Aug 10, 2017

Does the same happens if you don't have NC on your phone? Also internal or external storage?

@tobiasKaminsky
Copy link
Member Author

Internal storage and it also happens if no NC is installed.
So definitiv a bug of LineageOS/camera app.

@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Aug 10, 2017

After further testing:
those images that are 0b are in fact real images

  • ls -l on adb shell/terminal shows correct size
  • gallery in camera app shows correct size (com.android.gallery3d)
  • amaze, our app and a few others show the wrong size
  • while debugging I see that new File(pathOfStrangeFile).length also shows 0, which then leads to wrong upload

As some apps get the correct file length we should try to use also this approach to get a proper upload of those files.

@mario
Copy link
Contributor

mario commented Aug 10, 2017

2.0.1 then.

@vnidens
Copy link
Contributor

vnidens commented Aug 23, 2017

@tobiasKaminsky I don't have any device with LineageOS at this moment but have you checked what file size you get when you fetch it through ContentResolver using file's Uri? See this link.

@mario
Copy link
Contributor

mario commented Sep 6, 2017

@AndyScherzinger ? :D Why close this? xD

@AndyScherzinger
Copy link
Member

reopened... well, it auto closes since your PR said resolves 1295 and thus GH auto closes the issue when the PR is merged 😉

@tobiasKaminsky
Copy link
Member Author

Postponing as it is an edge case ;-)

@AndyScherzinger AndyScherzinger modified the milestones: Nextcloud App 2.0.1, Nextcloud App 2.1.0 Oct 4, 2017
@mario mario removed this from the Nextcloud App 2.1.0 milestone Jan 11, 2018
@mario
Copy link
Contributor

mario commented Jan 11, 2018

@tobiasKaminsky I have to postpone this. This happens on some phones to which I don't have access, but I'll steal your phone at hackweek and we can test.

@tobiasKaminsky
Copy link
Member Author

PR is #2185, but as noted there, it is unfortunately not 100% working all the time.

@stale
Copy link

stale bot commented May 10, 2019

This request did not receive an update in the last 4 weeks. Please take a look again and update the issue with new details, otherwise the issue will be automatically closed in 2 weeks. Thank you!

@stale stale bot added the stale label May 10, 2019
@stale stale bot closed this as completed May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants