Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App skeleton generator generates faulty info.xml when using characters like '&, <,'. Parser errors #1505

Open
Jelmerovereem opened this issue Oct 4, 2024 · 0 comments
Labels

Comments

@Jelmerovereem
Copy link

Jelmerovereem commented Oct 4, 2024

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

  1. Go to https://apps.nextcloud.com/developer/apps/generate and fill in some dummy data.
  2. Add one or more of the following characters inside the summary and/or description field(s): &, <
  3. Generate and download the app.
  4. xmllint the appinfo/info.xml file: xmllint appinfo/info.xml
  5. Observe the parser errors:
    Image
helloworld/appinfo/info.xml:6: parser error : xmlParseEntityRef: no name
        <summary>Test & test.</summary>

Expected behaviour

The app generator should generate an info.xml file that does not contain parser errors, regardless of what users fill in the app generator's fields.

Actual behaviour

The info.xml file throws parser errors when using 'illegal' characters. And because of the parser errors, Nextcloud cannot read the info.xml file correctly.
Image

helloworld/appinfo/info.xml:6: parser error : xmlParseEntityRef: no name
        <summary>Test & test.</summary>

Potential fix(es)

@Jelmerovereem Jelmerovereem changed the title App skeleton generator generates faulty info.xml when using characters like '&, <, >, (, ), {, }'. Parser errors App skeleton generator generates faulty info.xml when using characters like '&, <,'. Parser errors Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant