Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(navigation): scope all styles to the calendar app #6186

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Jul 22, 2024

Fix nextcloud/server#44638

Once again, our global app navigation styles leak to other apps. Scoping them should be a safe operation as the navigation sidebar on the left is not shown outside of the app.

Best reviewed as: https://github.com/nextcloud/calendar/pull/6186/files?w=1

Files is now fixed

Before After
image Screenshot_20240722_153705

No visual regressions

There are no visual regressions due to changed style precedence.

Before After
Screenshot_20240722_153627 Screenshot_20240722_153645

@st3iny st3iny added 3. to review Waiting for reviews bug design Related to design, interface, interaction design, UX, etc. regression Regression of a previous working feature labels Jul 22, 2024
@st3iny st3iny added this to the v5.0.0 milestone Jul 22, 2024
@st3iny st3iny self-assigned this Jul 22, 2024
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.97%. Comparing base (ffccb86) to head (307a265).
Report is 92 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6186   +/-   ##
=========================================
  Coverage     23.97%   23.97%           
  Complexity      457      457           
=========================================
  Files           247      247           
  Lines         11606    11606           
  Branches       2178     2188   +10     
=========================================
  Hits           2782     2782           
+ Misses         8509     8508    -1     
- Partials        315      316    +1     
Flag Coverage Δ
javascript 15.46% <ø> (ø)
php 59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@st3iny st3iny merged commit 470371d into main Jul 23, 2024
33 checks passed
@st3iny st3iny deleted the fix/navigation/scope-all-styles branch July 23, 2024 06:40
@st3iny
Copy link
Member Author

st3iny commented Aug 19, 2024

/backport to stable4.7

Ref nextcloud/mail#9933

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Aug 19, 2024
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Related to design, interface, interaction design, UX, etc. regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Files navigation shares submenu entries not indented
2 participants