Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors on contacts on initial NC 14 installation #586

Closed
TecJon opened this issue Jul 28, 2018 · 16 comments
Closed

Errors on contacts on initial NC 14 installation #586

TecJon opened this issue Jul 28, 2018 · 16 comments
Labels
3. to review Waiting for reviews compatibility Compatibility with other services

Comments

@TecJon
Copy link

TecJon commented Jul 28, 2018

Steps to reproduce

  1. Fresh installation of NC 14 beta 1
  2. Open contacts page

Expected behaviour

Option to add address book / contact
Nice layout

Actual behaviour

  • Settings button scrolled out of the view
  • No response when clicking on "+ new contact"
  • {{ctrl.t.emptySearch}} on screen when scrolling down
  • after adding address book, still no resposne when clicking on "+ new contact"

initial

After scrolling down
2

Server configuration

Nextcloud version: 14.0.0 Beta 1

Contacts version: 2.1.5

Updated from an older Nextcloud or fresh install: fresh

Signing status: no errors

Are you using external storage, if yes which one: no

Are you using encryption: no

Are you using an external user-backend, if yes which one: no

Client configuration

Browser: Edge, Chrome, Firefox

Operating system: Win 10

Logs

Browser log

Refused to execute script from 'https://cloud.example.com/apps/notifications/js/notifications.js?v=4554f71a-0' because its MIME type ('text/html') is not executable, and strict MIME type checking is enabled.
2angular.js:14199 Error: searchCallback must be a function
    at Search.initialize (search.js?v=4554f71a-0:55)
    at new Search (search.js?v=4554f71a-0:37)
    at new <anonymous> (search_service.js:45)
    at Object.instantiate (angular.js:4786)
    at Object.<anonymous> (angular.js:4625)
    at Object.invoke (angular.js:4771)
    at Object.$get (angular.js:4609)
    at Object.invoke (angular.js:4771)
    at angular.js:4569
    at d (angular.js:4716)
@skjnldsv skjnldsv added the wontfix This will not be worked on label Jul 28, 2018
@skjnldsv
Copy link
Member

@TecJon Thanks for reporting :)
Contacts won't be compatible for 14. A new update is coming for this.

f87c27a

@skjnldsv skjnldsv reopened this Jul 31, 2018
@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of compatibility Compatibility with other services and removed wontfix This will not be worked on labels Jul 31, 2018
@skjnldsv
Copy link
Member

Actually since I've done the error of releasing the past versions with 14 compatibility, I'll need to provide a patch for the old app while we wait for the new one :)
So I'll re-open this!

@editedweb
Copy link

The issue presents itself the same when doing an upgrade from 13 to 14 beta as well. That is, a populated address book shows the same - not just an issue for fresh installs.

@skjnldsv
Copy link
Member

skjnldsv commented Aug 2, 2018

@TecJon @cabaretboy can you try #588 please?

@TecJon
Copy link
Author

TecJon commented Aug 2, 2018

@skjnldsv Making sure I did the right steps.
I removed the old contacts app via the web interface. I unpacked the tar from #588 in apps/. Then go to apps on the nc web interface and enable contacts.

The app version which appears is still 2.1.5. After enabling it, it still says 2.1.5 only after refreshing the page it will say 2.1.6
2 5 1

The contacts page itself is empty and shows a spinner on the left side. Settings button is disabled.

contacts

Happens on two test installations. Both should have zero addressbooks/contacts

@skjnldsv
Copy link
Member

skjnldsv commented Aug 2, 2018

@TecJon please make sure you cleared your cache :)
Otherwise procedure is fine

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Aug 2, 2018
@TecJon
Copy link
Author

TecJon commented Aug 2, 2018

Alright 😃
Here's the Edge browser log

JQMIGRATE: Migrate is installed, version 1.4.0 New search handler registered querying Whats New data was successful: nocontent undefined HTML1300: Navigation occurred. contacts (1,1) 2 CSP14309: Unknown directive 'manifest-src' in Content-Security-Policy - directive will be ignored. CSS3121: The media query -ms-viewport has been deprecated. 4 HTML1500: Tag cannot be self-closing. Use an explicit closing tag. contacts (94,21) HTML1508: Unmatched end tag. contacts (214,50) 2 SEC7112: Script from https://example.com/apps/files/ was blocked due to mime type mismatch contacts (1,1) JQMIGRATE: Migrate is installed, version 1.4.0

heres Chromes:
Refused to execute script from 'https://example.com/apps/contacts/js/contacts-inject-14.js?v=2df6b6be-0' because its MIME type ('text/html') is not executable, and strict MIME type checking is enabled.

Site behaves the same everywhere

@skjnldsv
Copy link
Member

skjnldsv commented Aug 2, 2018

Refused to execute script from 'https://example.com/apps/contacts/js/contacts-inject-14.js?v=2df6b6be-0' because its MIME type ('text/html') is not executable, and strict MIME type checking is enabled.

That is strange. Let me check!

@skjnldsv
Copy link
Member

skjnldsv commented Aug 2, 2018

@TecJon I updated the OP on #588 There was an issue in the build package.
Please try again :)

@TecJon
Copy link
Author

TecJon commented Aug 2, 2018

@skjnldsv you mean https://github.com/nextcloud/contacts/files/2252661/contacts.tar.gz right? Same behavior. Also with a cleared cache it will say 2.1.5 first.

@skjnldsv
Copy link
Member

skjnldsv commented Aug 2, 2018

@skjnldsv
Copy link
Member

skjnldsv commented Aug 2, 2018

@TecJon Better? :)

@TecJon
Copy link
Author

TecJon commented Aug 2, 2018

Alright. This one works 😃

Some design issues I have found:

  • contact width not 100%
  • loading spinner positioned weird in chrome and firefox
  • When scrolling down on the contact, the list is also shifted up (not scrolled). See last screenshot. The list doesn't end there so it shouldn't shift.
  • After scrolling through the list, I cannot scroll on the contact for 2 seconds
  • Scrolling seems buggy in Chrome. It often responds after 1-2 seconds and results in shifting and scrolling the contact list.
  • address book name input field has a red border for some reason
  • "no contacts info" not centered
  • the weird email label on the last screenshot is in vcf "ITEM1.EMAIL;TYPE=INTERNET,pref:" in iOS simply "other"

contacts2

nocontacts

Spinner at the top of the contact list, overlapping with the list, the navbar and the content. Can also be scrolled away.
spinner

contac

Since I had zero contacts on my test installation I tried to import an old contacts dump file. It worked quite well and I really liked the visual feedback on the web interface. At around 80% I got several Failed to load resource: net::ERR_SPDY_PROTOCOL_ERROR errors in the browser log and 170 Failed to load resource: the server responded with a status of 504 ()

@skjnldsv
Copy link
Member

skjnldsv commented Aug 2, 2018

@TecJon Okay, I'm guessing most of the design will be fixed on the new beta. We merged quite a lot of design fixes for this :)

Can you confirm you're not on server@master ?

Also: the 504 error, the import issues and the label are not related as this is not the point of this 14 compatibility update ;)

@TecJon
Copy link
Author

TecJon commented Aug 2, 2018

Cool, I'm happy to hear that.

Can you confirm you're not on server@master ?

What exactly do you mean by that? I am on the update channel beta and have installed beta 1

@skjnldsv
Copy link
Member

skjnldsv commented Aug 2, 2018

@TecJon that answers my question. I wanted to make sure you were on the beta1 and did not updated to the latest git version on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews compatibility Compatibility with other services
Projects
None yet
Development

No branches or pull requests

3 participants