Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure to remove "user_external" from 15.0.2 build #598

Closed
violoncelloCH opened this issue Jan 9, 2019 · 5 comments
Closed

make sure to remove "user_external" from 15.0.2 build #598

violoncelloCH opened this issue Jan 9, 2019 · 5 comments

Comments

@violoncelloCH
Copy link
Member

@nextcloud/docker
We removed the app user_external from the build for 15.0.1 and released it via appstore -- see:
nextcloud/user_external#22
nextcloud/server#13225
https://apps.nextcloud.com/apps/user_external

as you use a separate folder (custom_apps) for store apps, the old version is kept in the apps folder and not overwritten by the store update (this already happened in user_external#32 for the ones that already updated the app in 15.0.0)
can you make sure to remove the shipped version in apps/ for the update to 15.0.1 when the appstore version is installed to custom_apps/?

cc @MorrisJobke

@J0WI
Copy link
Contributor

J0WI commented Jan 9, 2019

I assume that rsync will handle this case:

rsync $rsync_options --delete --exclude-from=/upgrade.exclude /usr/src/nextcloud/ /var/www/html/

@violoncelloCH
Copy link
Member Author

If this will remove user_external v0.4 form the apps/ directory also on upgrade that should be fine! Then user_external v0.5.0 can be installed from the appstore to custom_apps/ without any conflict...

@J0WI
Copy link
Contributor

J0WI commented Jan 11, 2019

@violoncelloCH the now published 15.0.1 release does still ship with user_external 0.4

@violoncelloCH
Copy link
Member Author

happened by accident -- see: nextcloud/server#13346 (comment)
15.0.2 won't ship it anymore...

@violoncelloCH violoncelloCH changed the title make sure to remove "user_external" from 15.0.1 build make sure to remove "user_external" from 15.0.2 build Jan 11, 2019
@J0WI
Copy link
Contributor

J0WI commented Jan 11, 2019

Thanks for the heads up, I verified the app is getting removed in 15.0.2.

@J0WI J0WI closed this as completed Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants