Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

Sharing page header should follow the new layout introduced in Nextcloud 13 #358

Closed
danxuliu opened this issue Jan 8, 2018 · 6 comments
Closed

Sharing page header should follow the new layout introduced in Nextcloud 13 #358

danxuliu opened this issue Jan 8, 2018 · 6 comments
Labels
design Related to the design papercut Small issues that doesn't break the ux/ui
Milestone
Nextcloud 14

Comments

@danxuliu
Copy link
Member

danxuliu commented Jan 8, 2018

As currently the master branch is compatible only with Nextcloud 13 and later the header shown in the sharing page should follow the new layout introduced in Nextcloud 13.

Right now when the file list is being shown in the sharing page the new header is used, but when the Toggle gallery button is clicked the new header is replaced with the old one.

@nextcloud/designers
@danxuliu danxuliu added design Related to the design feature:sharing labels Jan 8, 2018
@danxuliu danxuliu mentioned this issue Jan 8, 2018
Open
@MorrisJobke MorrisJobke added the papercut Small issues that doesn't break the ux/ui label Jan 8, 2018
@MorrisJobke MorrisJobke added this to the Nextcloud 13 milestone Jan 8, 2018
@danxuliu
Copy link
Member Author

Related issue in server: nextcloud/server#6553

@MorrisJobke
Copy link
Member

Time is up for this one -> 13.0.1

@MorrisJobke
Copy link
Member

Will this be ready by later today or should we move it to 13.0.2? nextcloud/server#8748

@juliushaertl
Copy link
Member

I would just move this to 14 since we can then use the new PublicPageResponse from nextcloud/server#6553. Otherwise we need to workaround for 13 and do an additional implementation for 14.

Related issue for the PublicPageResponse migration #403

@juliushaertl juliushaertl mentioned this issue Apr 5, 2018
Merged
@juliushaertl
Copy link
Member

Fix is in #425

@MorrisJobke
Copy link
Member

Fixed with #425

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
design Related to the design papercut Small issues that doesn't break the ux/ui
Projects
None yet
Milestone
Nextcloud 14
Development

No branches or pull requests
3 participants
@MorrisJobke @juliushaertl @danxuliu