Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing folders will sent email share accept invites, which are causing issues #1203

Open
melroy89 opened this issue Jul 12, 2024 · 0 comments
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working

Comments

@melroy89
Copy link

melroy89 commented Jul 12, 2024

As stated in your own README:

Guest users automatically accept all files and folders that are shared with them. This is in constract to regular full users (who have to actively accept incoming shares since Nextcloud 18).

Issue: Nextcloud is still sending e-mail accept invites after sharing another folder with a guest account. When that user tries to click on that accept invite email link (/apps/files_sharing/accept/ocinternal:29 path), the user will get an error message: "Access to this resource is forbidden for guests".

The user actually does have access, if the user just login and look at their folders on the root level. That being said, it's very confusing for the guest users who are getting this email.

Expected behavior: No unnecessary and invalid email invites when sharing additional files or folders.

Solution: Since sharing folders are accepted by default, avoid sending an invite email for sharing additional folders. Try to validate if the user is already active (eg. has a password been set) and do not send any more mail invites.

Thanks!

@joshtrichards joshtrichards added bug Something isn't working 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants