feat(nextcloud): add interceptors #2165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested changes
Jun 12, 2024
There was a problem hiding this comment.
LGTM, but can you also migrate the nextcloud_test part that records the fixtures to these new interceptors?
Also we just use our own custom solution instead of https://pub.dev/packages/http_interceptor?
|
Marking as draft as this interceptor implementation does not allow any caching interceptor. |
3 tasks
|
I'd like to merge this as is (after fixing the tests and adding separate ones for the interceptors). |
provokateurin
requested changes
Jul 4, 2024
Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
Users should migrate to the CookieInterceptor Signed-off-by: Nikolas Rimikis <[email protected]>
Leptopoda
force-pushed
the
feat/nextcloud/http_interceptor
branch
from
1974b00
to
d995854
Compare
|
The CI failure looks like the cookies are not applied |
This was referenced Jul 16, 2024
|
@Leptopoda close this in favor of #2288? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I separated commits per package to make the changelogs cleaner.
I can do separate PRs if it helps for reviewability (although I think it's quite clean).