Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading translations and add test cases #571

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 26, 2023

There is a small issue which completely changed the behavior of loadTranslation to be synchronous while it should be (and is in OC.L10N) asynchronous. This is fixed, also added more information if the request fails.

Added test cases for loadTranslation

before after
code coverage 60.91% statements 13.5% branches code coverage 80.89% statements 18.85% branches

@susnux susnux added the bug Something isn't working label Jan 26, 2023
Also added more information on error

Signed-off-by: Ferdinand Thiessen <[email protected]>
@skjnldsv skjnldsv merged commit 34d5979 into master Jan 26, 2023
@skjnldsv skjnldsv deleted the fix/loadTranslations branch January 26, 2023 18:15
@susnux
Copy link
Contributor Author

susnux commented Feb 1, 2023

Could we have a 2.0.2 release for this?
(I think only users with admin permission can prepare a release 😅 )

@susnux susnux mentioned this pull request Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants