Skip to content

Commit

Permalink
Do not allow disabled links (#557)
Browse files Browse the repository at this point in the history
Do not allow disabled links
  • Loading branch information
skjnldsv authored Aug 29, 2019
2 parents 907bbbd + f860d8e commit e2e9d8d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 16 deletions.
1 change: 1 addition & 0 deletions src/components/ActionButton/ActionButton.vue
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ This component is made to be used inside of the [Actions](#Actions) component sl
<Actions>
<ActionButton icon="icon-delete" @click="alert('Delete')">Delete</ActionButton>
<ActionButton icon="icon-delete" @click="alert('Delete')">Delete</ActionButton>
<ActionButton icon="icon-delete" :disabled="true" @click="alert('Disabled')">Disabled button</ActionButton>
</Actions>
```

Expand Down
9 changes: 1 addition & 8 deletions src/components/ActionLink/ActionLink.vue
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ This component is made to be used inside of the [Actions](#Actions) component sl
:download="download"
:href="href"
:target="target"
:class="['action-link', { focusable: isFocusable }]"
class="action-link focusable"
rel="noreferrer noopener"
@click="onClick">

Expand Down Expand Up @@ -113,13 +113,6 @@ export default {
validator: value => {
return ['_blank', '_self', '_parent', '_top'].indexOf(value) > -1
}
},
/**
* Disabled state of the link
*/
disabled: {
type: Boolean,
default: false
}
},
computed: {
Expand Down
9 changes: 1 addition & 8 deletions src/components/ActionRouter/ActionRouter.vue
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<li :class="{ 'action--disabled': disabled }">
<router-link :to="to"
:exact="exact"
:class="[ 'action-router', { focusable : isFocusable }]"
class="action-router focusable"
rel="noreferrer noopener">
<!-- icon -->
<span :class="[isIconUrl ? 'action-router__icon--url' : icon]"
Expand Down Expand Up @@ -81,13 +81,6 @@ export default {
exact: {
type: Boolean,
default: false
},
/**
* Disabled state of the router
*/
disabled: {
type: Boolean,
default: false
}
},
computed: {
Expand Down

0 comments on commit e2e9d8d

Please sign in to comment.