Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable previous and next image on recommendations #325

Open
jakobroehrl opened this issue Oct 25, 2020 · 6 comments
Open

Disable previous and next image on recommendations #325

jakobroehrl opened this issue Oct 25, 2020 · 6 comments
Labels
1. to develop bug Something isn't working good first issue Good for newcomers

Comments

@jakobroehrl
Copy link

The previous and next image in the https://github.com/nextcloud/recommendations and recommendation Dashboard are most of the time wrong

@skjnldsv
Copy link
Member

cc @juliushaertl

@juliushaertl
Copy link
Member

I'm not sure how we can solve this, as the viewer will just fetch the file listing of the directory that the file is in and use the next/previous image from there. @skjnldsv Is there a way we can block the next/previous navigation when calling OCA.Viewer.open?

@juliushaertl
Copy link
Member

Ah I guess we could just pass the list of only recommended files to it:

	 * @param {Object[]} [options.list] the list of files as objects (fileinfo) format

@skjnldsv
Copy link
Member

skjnldsv commented Nov 2, 2020

Yes, if you pass the array containing the single fileInfo, it won't display any other thing 👍
You can also pass the recommended files filesList so next would just go to the second one.

@skjnldsv
Copy link
Member

skjnldsv commented Nov 2, 2020

@skjnldsv Is there a way we can block the next/previous navigation when calling OCA.Viewer.open?

I've been thinking about adding options for viewer, such as modal-sizes (normal/full) from models, or booleans toggle on viewer.open such as disable fetching etc etc.
Don't know if that is worth it though 🤔

@juliushaertl
Copy link
Member

Don't know if that is worth it though thinking

I'd say just passing the filelist array is the way to go then. I don't see a reason for another flag yet.

Let me move this over to recommendations.

@juliushaertl juliushaertl transferred this issue from nextcloud/viewer Nov 2, 2020
@juliushaertl juliushaertl added 1. to develop bug Something isn't working good first issue Good for newcomers labels Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants