Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration email not optional #497

Open
Aonodensetsu opened this issue Jan 5, 2023 · 7 comments
Open

Registration email not optional #497

Aonodensetsu opened this issue Jan 5, 2023 · 7 comments

Comments

@Aonodensetsu
Copy link

Steps to reproduce

  1. Set up registration with "Email is optional" toggle enabled
  2. Try to register without giving an email

Expected behaviour

The website allows registration to go through

Actual behaviour

A "this field is required" popup appears

Server configuration

Nextcloud version: 25.0.2

@nickvergessen
Copy link
Member

That's right, the email is still needed as it's the unique login attribute afterwards. It simply skips the verification where you have to enter a random secret that is emailed to the address.

@Aonodensetsu
Copy link
Author

(sorry for late reply) Could the username not be treated as unique in that situation? I have a mail server connected to the NC user database which provisions accounts for new users, I'd rather them not use an external email in addition to the provisioned one.

@vszakats
Copy link

vszakats commented Jun 2, 2023

I expected "Email is optional" to mean that email can be left empty on registration (or even better: not asked for at all at this stage), and most importantly: mean that the server doesn't need to collect and store this personal data. If "Email is optional" means "Disable email confirmation", it'd probably be better to call it that.

It's concerning (or at least good to be aware of) that the internal design of Nextcloud server requires an email address for each user profile (if I understand correctly). I'd argue an email address should be optional by design and used for specific purposes based on policies and settings.

@aradrd
Copy link

aradrd commented Aug 30, 2023

That's right, the email is still needed as it's the unique login attribute afterwards. It simply skips the verification where you have to enter a random secret that is emailed to the address.

A bit late to the party here, but it seems there's another toggle named "Disable email verification" that only shows up when "Email is optional" is disabled. What does that one do then?

@NeverLoseHope777
Copy link

I would also like to give people who do not have an e-mail address or do not wish to provide one the opportunity to register. Unfortunately, this is currently not possible.

@smooroodina
Copy link

Why not possible?

I was able to completely hide the email input process from new users by making a few modifications to this app's source code.

The new registration process I modified is as follows:

  • When you press the Register button on the login page, a form for entering loginname and password is displayed immediately without going through the email input process.
  • Also, there is no email input(pre-filled and disabled) in this form.
    image
  • Fill out the form and submit. New account registration successful.

loginname is already a unique ID value, so there will be no account conflict issues even if a unique email address is not specified.
since the "Disable email verification" option is already selectable, I see no reason why there shouldn't be an option to completely remove the email requirement from the sign-up process.

I am not yet a contributor to nextcloud. I am willing to submit a pull request after further testing the stability of the modified functionality, but I may have made inappropriate changes to the app's architecture and framework.

So, for now... I just wanted to say that it is fully possible to implement.

@Areopagitics
Copy link

Why not possible?

I was able to completely hide the email input process from new users by making a few modifications to this app's source code.

The new registration process I modified is as follows:

  • When you press the Register button on the login page, a form for entering loginname and password is displayed immediately without going through the email input process.
  • Also, there is no email input(pre-filled and disabled) in this form.
    image
  • Fill out the form and submit. New account registration successful.

loginname is already a unique ID value, so there will be no account conflict issues even if a unique email address is not specified. since the "Disable email verification" option is already selectable, I see no reason why there shouldn't be an option to completely remove the email requirement from the sign-up process.

I am not yet a contributor to nextcloud. I am willing to submit a pull request after further testing the stability of the modified functionality, but I may have made inappropriate changes to the app's architecture and framework.

So, for now... I just wanted to say that it is fully possible to implement.

@smooroodina How is the testing coming along? Any updates on a merge? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants