Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File explorer: actions hidden behind "..." menu now #11116

Closed
mathiasconradt opened this issue Sep 8, 2018 · 16 comments
Closed

File explorer: actions hidden behind "..." menu now #11116

mathiasconradt opened this issue Sep 8, 2018 · 16 comments
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: files good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@mathiasconradt
Copy link

mathiasconradt commented Sep 8, 2018

NC14 cloud.nextcloud.com

Why is there a "..." menu for the actions, requiring two clicks to trigger the action, when there is enough space on the screen, especially when this action bar is only visible when at least one file is selected, so the many action items don't actually pollute the screen during regular usage?

image

This is a step backwards to as it was before, where the actions were available right away. This "..." menu should only show on small screens.

@mathiasconradt mathiasconradt added enhancement design Design, UI, UX, etc. labels Sep 8, 2018
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #3584 (File actions menu entries too light), #3183 (Mimetype detection for hidden files), #10749 (Copy File Name context menu option), #4557 (Missing tooltips in contacts menu actions.), and #189 (Hide hidden files from UI).

@jospoortvliet
Copy link
Member

@nextcloud/designers I must admit I also spend a bit of time looking for the move action... maybe only hide if needed? It only shows when relevant anyway.

@skjnldsv
Copy link
Member

@jancborchardt :)

@MorrisJobke
Copy link
Member

@jancborchardt :)

🏓

@jancborchardt
Copy link
Member

1 action should indeed be shown directly, and in this case that's "Move or Copy". (Same pattern as for the Share function and 3-dot-menu in the file list.)

@microfx
Copy link

microfx commented Oct 7, 2018

@jancborchardt I have plenty of space so it should only be hidden when necessary.

Is this something that will stay now like this?

@jancborchardt
Copy link
Member

jancborchardt commented Dec 21, 2018

@microfx as said:

1 action should indeed be shown directly, and in this case that's "Move or Copy". (Same pattern as for the Share function and 3-dot-menu in the file list.)

The necessity of hiding things does not depend on the available screen space, but on the mental load that showing everything at once would cause.

@jancborchardt jancborchardt added good first issue Small tasks with clear documentation about how and in which place you need to fix things in. feature: files labels Dec 21, 2018
@tomasz-grobelny
Copy link
Contributor

1 action should indeed be shown directly, and in this case that's "Move or Copy". (Same pattern as for the Share function and 3-dot-menu in the file list.)

I agree that one action may be a primary one, but why should it be "Move or Copy"? Maybe for some people the "Download" option will be the most used one?

How about some configuration option? Ok, just joking - I know how evil they are. But maybe some simple machine learning to select most used one based on different factors (folder location, primary folder contents, folder age)?

@jancborchardt
Copy link
Member

I agree that one action may be a primary one, but why should it be "Move or Copy"? Maybe for some people the "Download" option will be the most used one?

We simply have to decide on one. If we would have sharing in multiselect, that would be the one. So right now it’s just the entry that’s first in the list. We could also say that "Move or copy" is related to Nextcloud, while "Download" is not.

Anyhow, details. The only real issue here is that someone needs to implement it. :)

How about some configuration option? Ok, just joking - I know how evil they are. But maybe some simple machine learning to select most used one based on different factors (folder location, primary folder contents, folder age)?

Sure that’s a nice concept, but a lot of overhead for such a simple thing. And as @ChristophWurst will be able to tell, machine learning is not proper here since you need a huge data set as base. :)

@tomasz-grobelny
Copy link
Contributor

How about some configuration option? Ok, just joking - I know how evil they are. But maybe some simple machine learning to select most used one based on different factors (folder location, primary folder contents, folder age)?

Sure that’s a nice concept, but a lot of overhead for such a simple thing. And as @ChristophWurst will be able to tell, machine learning is not proper here since you need a huge data set as base. :)

ML is certainly not the first choice here and requires some design/coding that will not happen of itself overnight. Sure. But I am not sure what you mean by "huge data set"? Note that each click may provide data for the model.

@jancborchardt
Copy link
Member

We’re getting off-topic here. :)

@skjnldsv
Copy link
Member

What shall we do then? Close this issue? Let's not leave issues open for nothing I'd say :)
Let's take a position? What do you think?

@juliushaertl
Copy link
Member

I think this enhancement proposal by @jancborchardt is still valid:

1 action should indeed be shown directly, and in this case that's "Move or Copy". (Same pattern as for the Share function and 3-dot-menu in the file list.)

@janis91
Copy link

janis91 commented May 28, 2019

It'd also be very nice for app developers to be able to register file actions in that menu. As far as I see this is only possible for single files, yet. Regardless of the design it would be a big benefit, because then app developers can just register the action and even if design and arrangement changes over time (eg. most used option will be shown or something like this), this will not force devs to adjust their code.

@janis91
Copy link

janis91 commented May 28, 2019

It'd also be very nice for app developers to be able to register file actions in that menu. As far as I see this is only possible for single files, yet. Regardless of the design it would be a big benefit, because then app developers can just register the action and even if design and arrangement changes over time (eg. most used option will be shown or something like this), this will not force devs to adjust their code.

Ok nevermind. I just found out, that not only design has changed. OCA.Files.App.fileList.multiSelectMenuItems can be used to register (by pushing) an action.

@skjnldsv skjnldsv added the 1. to develop Accepted and waiting to be taken care of label Jun 12, 2019
@szaimen
Copy link
Contributor

szaimen commented May 21, 2021

I'm closing this issue due to inactivity. Please reopen if you still want to implement this.

@szaimen szaimen closed this as completed May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: files good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Development

No branches or pull requests