Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar should show full file name #12003

Closed
pellaeon opened this issue Oct 24, 2018 · 14 comments
Closed

Sidebar should show full file name #12003

pellaeon opened this issue Oct 24, 2018 · 14 comments
Assignees
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: files papercut Annoying recurring issue with possibly simple fix.

Comments

@pellaeon
Copy link
Contributor

There are enough spaces in sidebar, we should show the full file name, instead of requiring the user to hover over to see the full.

2016-01-12 11 45 49

Expected behavior

Sidebar shows the full file name, no tooltips.

Reference

This issue has been raised in 2016 owncloud/core#21636
Recently I developed an app to overcome this, but rejected, @MorrisJobke asked me to open an issue here.
Please read the discussions in the above two links as well.

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #10673 (Show files details sidebar always ), #3578 (Version Control activities are not showed in File activities), #11905 (Add icon to file sidebar tabs), #2259 (Activity sidebar shows "public_shared_file_downloaded" ), and #10289 (Sidebar standardization).

@MorrisJobke
Copy link
Member

cc @nextcloud/designers Please have a look at this - I think it is quite crucial to fix this. Also should be addressed in the context of the grid view (#11573).

@MorrisJobke MorrisJobke added design Design, UI, UX, etc. feature: files papercut Annoying recurring issue with possibly simple fix. labels Oct 24, 2018
@juliushaertl
Copy link
Member

Looks totally fine to me if we just remove the ellipsis and allow the filename to have multiple lines. 👍

image

@skjnldsv
Copy link
Member

Yes, the filenames won't probably have more than 2 lines anyway :)

@jancborchardt
Copy link
Member

Yes, the filenames won't probably have more than 2 lines anyway :)

Hehehe ;D we can’t really expect this.

I’m fine with showing 2 lines for Files here. We shouldn’t allow that for others for now though, like say Talk conversation names. And we should limit it to 2 lines max, because otherwise a very long filename will just occupy everything, even though it’s not the most important thing in the sidebar.

Ok @juliushaertl @skjnldsv @MorrisJobke?

@skjnldsv
Copy link
Member

And we should limit it to 2 lines max

This is where css fails! css clamp is not supported enough, but we can set the height to 2x line height and use clamp to ellipsis o supported browsers or just hide overflow on unsupported ones)

@jancborchardt
Copy link
Member

Ok – for the record, I’d rather have it stay limited to 1 line like now, than risk it being all messed up with many lines or non-consistent 2-lines.

So maybe we need to wait a bit with this for compatibility?

@skjnldsv
Copy link
Member

skjnldsv commented Oct 30, 2018

@jancborchardt it will be consistent enough, just the ... can be missing on some browsers :)
https://caniuse.com/#feat=css-line-clamp

Still 85% supported ;)

@weeman1337
Copy link
Member

I had some struggle with that in the last time.

My conclusion for line clamp is: Don't do it because of the lack of support. And don't use any polyfill or JavaScript since they all came up with limitations or bugs. I really spent many hours with that. Neither solution I tried worked.

What works for me is having some CSS fading out the text. It's based on an after element that overlays the end of the text:

image

Maybe that could be done in a mixin and can be replaced by real line clamp when it's supported by Firefox and IE doesn't have to be supported any more.

@weeman1337
Copy link
Member

Anyway I could have a look at this one if we go for the "max. two instead of one line file name" solution.

@weeman1337 weeman1337 self-assigned this Dec 8, 2018
@jancborchardt
Copy link
Member

@weeman1337 that seems good! It’s definitely not something of crucial importance, so don’t waste too much time on it. Maybe if we revisit it in 1–2 years, support will be much better.

@skjnldsv skjnldsv added the 1. to develop Accepted and waiting to be taken care of label Jun 12, 2019
@pellaeon
Copy link
Contributor Author

I'd like to again raise attention to this issue. It has been two years and there is still no way of viewing the full filename in the sidebar. Even the tooltip no longer shows.

@skjnldsv
Copy link
Member

We can most likely start using https://caniuse.com/css-line-clamp now that we dropped ie11

@szaimen
Copy link
Contributor

szaimen commented Jul 21, 2021

I think this was fixed with #28046

@szaimen szaimen closed this as completed Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: files papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants