Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show expiration date on receiving shares #15819

Open
1 of 5 tasks
Tracked by #3085
skjnldsv opened this issue May 31, 2019 · 25 comments
Open
1 of 5 tasks
Tracked by #3085

Show expiration date on receiving shares #15819

skjnldsv opened this issue May 31, 2019 · 25 comments

Comments

@skjnldsv
Copy link
Member

skjnldsv commented May 31, 2019

@skjnldsv skjnldsv added enhancement design Design, UI, UX, etc. 1. to develop Accepted and waiting to be taken care of feature: sharing labels May 31, 2019
@MorrisJobke
Copy link
Member

For internal shares this should go into the sidebar right? For the public shares it should be at a similar location as the note already is or do you have a better idea?

@skjnldsv
Copy link
Member Author

I was indeed thinking about user shares, like having a small calendar/time icon and a popup with the remaining time :)
No idea on the public shares! @nextcloud/designers ?

@jancborchardt
Copy link
Member

Would agree with @MorrisJobke this should go in the sidebar if anything. And for public shares it should also go into the to-be-added sidebar (for comments etc).

@skjnldsv
Copy link
Member Author

Something like that? :)
Capture d’écran_2019-05-31_13-28-54

@jancborchardt
Copy link
Member

Ah ok, you mean for the sender?

In that case it should either be a subline (like the "Connect items to a project …" is for "Add to a project") or the icon should overlay the 3-dot menu so when you click, the relevant controls are opened. (Or both.)

@skjnldsv
Copy link
Member Author

Nono, the mockup is wrong since it comes from the sender part, you're right.
I mean for the receiving share :)

@jancborchardt
Copy link
Member

Ok, then how about my suggestion above for the sender part, and this for recipient:
sharing expiry

@skjnldsv
Copy link
Member Author

skjnldsv commented May 31, 2019

Awesome! 👍

@tobiasKaminsky
Copy link
Member

This should then also be done on clients, or?

@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 7, 2019

Ideally yes

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Jul 12, 2019
@skjnldsv
Copy link
Member Author

Capture d’écran_2019-07-12_12-52-45

@tobiasKaminsky
Copy link
Member

I think it should either be
"expires in 18 days" as in "Folder xy share expires in 18 days"
or
"will expire in 18 days" as in "Folder xy share will expire in 18 days"

@tobiasKaminsky
Copy link
Member

BTW: how do you get the 18 days info?

@skjnldsv
Copy link
Member Author

Capture d’écran_2019-07-12_15-52-40

@tobiasKaminsky
Copy link
Member

hm.
Can't we have "shared_with_me" query somewhere in propfind?
We do only need expiration, ownerId and owner display name.
Later two are already there.

This way we could omit a new query…

@jancborchardt
Copy link
Member

@skjnldsv just nitpicks:

  • "Expires" with -s and capital E. "Expires in 4 days"
  • The subline should have text color maxcontrast so it’s not so present as the text above.

@skjnldsv
Copy link
Member Author

@jancborchardt fixed already (after the screenshot ;) )

@wiswedel
Copy link
Contributor

Related: #15680

@marinofaggiana
Copy link
Member

hm.
Can't we have "shared_with_me" query somewhere in propfind?
We do only need expiration, ownerId and owner display name.
Later two are already there.

This way we could omit a new query…

true ... where we can find the expiration date ?

@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 2, 2019

true ... where we can find the expiration date ?

look at the content of the screenshot above

@marinofaggiana
Copy link
Member

yes, true, but would be more correct in propfind near

"<owner-id xmlns=\"http://owncloud.org/ns\"/>" "<owner-display-name xmlns=\"http://owncloud.org/ns\"/>"
?

@tobiasKaminsky
Copy link
Member

@skjnldsv the property is not available via dav file query, but only via share endpoint.
On client we want to query this all in once, so it would be very good to have this info also in dav.

@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 2, 2019

@tobiasKaminsky that's a different issue ^^

@tobiasKaminsky
Copy link
Member

Indeed: #16967

@skjnldsv
Copy link
Member Author

#15719 is merged, go go go Clients :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants