Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tabs to vue #20020

Closed
3 of 4 tasks
skjnldsv opened this issue Mar 18, 2020 · 16 comments
Closed
3 of 4 tasks

Migrate tabs to vue #20020

skjnldsv opened this issue Mar 18, 2020 · 16 comments
Labels
2. developing Work in progress enhancement feature: file sidebar Related to the file sidebar component feature: files
Milestone

Comments

@skjnldsv
Copy link
Member

skjnldsv commented Mar 18, 2020

Now that we got a proper standalone sidebar, we need to make the last tabs standalone too:

Refs: #17737 #15719, might conflict with #658
cc @nextcloud/javascript

@matiasdelellis

This comment has been minimized.

@skjnldsv skjnldsv added this to the Nextcloud 20 milestone May 1, 2020
@skjnldsv
Copy link
Member Author

skjnldsv commented May 1, 2020

Hey! Unfortunately, the main sidebar requires a vue component yes.
We plan to improve this so anything can be registered in the future.

@matiasdelellis

This comment has been minimized.

@skjnldsv
Copy link
Member Author

skjnldsv commented May 1, 2020

Ohh. I did not want to learn vue .. I guess I will have to try.

Yeah, sorry :)
You can still use the old legacy way though.
See how we do for the old tabs like comments

@skjnldsv
Copy link
Member Author

skjnldsv commented May 1, 2020

Wait, you actually already had a tab. So it should still works.
You shouldn't have to change anything for it to work with the new sidebar.

@matiasdelellis

This comment has been minimized.

@skjnldsv
Copy link
Member Author

skjnldsv commented May 1, 2020

Yes, but it was not shown in photos because before dont manage the LoadSidebar event. Now fix this, but it doesn't work.

Ah, it will no work in photos.
You need to make sure it's compatible with the new standard then. We ketp compatibiliy for files for legacy tabs. But you still need to have a proper implementation to support the global sidebar. Sorry for the misanderstanding 😕

@e-alfred
Copy link

This should be part of #20953 it seems.

@enochterrymize

This comment has been minimized.

@skjnldsv skjnldsv modified the milestones: Nextcloud 22, Nextcloud 23 Jul 5, 2021
@blizzz blizzz removed this from the Nextcloud 23 milestone Nov 30, 2021
@blizzz blizzz added this to the Nextcloud 24 milestone Nov 30, 2021
@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Oct 19, 2022
@PVince81
Copy link
Member

versions was done in #34769

@artonge
Copy link
Contributor

artonge commented Dec 5, 2022

Just discovered this tracking ticket: activity was done last year nextcloud/activity#581

@szaimen
Copy link
Contributor

szaimen commented Dec 5, 2022

So everything done then? :)

@artonge
Copy link
Contributor

artonge commented Dec 5, 2022

Tags are not done yet

@szaimen
Copy link
Contributor

szaimen commented Dec 5, 2022

Tags are not done yet

I thought they dont have a separate tab and are already inregrated into the sidebar?

@artonge
Copy link
Contributor

artonge commented Dec 5, 2022

Not sure if @skjnldsv still wants to track them. Let's wait for his input tomorrow :)

@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 6, 2022

I thought they dont have a separate tab and are already inregrated into the sidebar?

But they're still not vue :)
There is a ticket about this laying somewhere i think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress enhancement feature: file sidebar Related to the file sidebar component feature: files
Projects
None yet
Development

No branches or pull requests

10 participants