Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments are not marked as read #23877

Closed
MorrisJobke opened this issue Nov 3, 2020 · 5 comments · Fixed by #32775
Closed

Comments are not marked as read #23877

MorrisJobke opened this issue Nov 3, 2020 · 5 comments · Fixed by #32775
Labels
1. to develop Accepted and waiting to be taken care of 27-feedback bug feature: comments feature: file sidebar Related to the file sidebar component needs info regression
Milestone

Comments

@MorrisJobke
Copy link
Member

  • having a file shared from user1 to user2
  • as user1 comment on that file
  • as user2 I see an unread comment icon in the file list
  • clicking on the icon should open the comments in the sidebar
  • actual: unread comment icon is still there (also after page reload)
  • expected: unread comment icon should not be there and the comments should be marked as read

cc @skjnldsv

@MorrisJobke MorrisJobke added bug 1. to develop Accepted and waiting to be taken care of feature: comments regression feature: file sidebar Related to the file sidebar component labels Nov 3, 2020
@MorrisJobke MorrisJobke added this to the Nextcloud 21 milestone Nov 3, 2020
@MorrisJobke
Copy link
Member Author

Most likely related to #23173

@skjnldsv
Copy link
Member

skjnldsv commented Nov 4, 2020

Oh interesting, I thought that would be linked to the api requests or something.
How is it done?

@ImaCrea
Copy link

ImaCrea commented Jan 19, 2022

Hello there,
I see this bug seem to be postponed from one version to another. I was wondering if we could reasonably hope it will be fixed for the next release please?

Thanks :)

@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
@blizzz blizzz removed this from the Nextcloud 25 milestone Oct 19, 2022
@blizzz blizzz added this to the Nextcloud 26 milestone Oct 19, 2022
@szaimen
Copy link
Contributor

szaimen commented Jan 23, 2023

Hi, please update to 24.0.9 or better 25.0.3 and report back if it fixes the issue. Thank you!

My goal is to add a label like e.g. 25-feedback to this ticket of an up-to-date major Nextcloud version where the bug could be reproduced. However this is not going to work without your help. So thanks for all your effort!

If you don't manage to reproduce the issue in time and the issue gets closed but you can reproduce the issue afterwards, feel free to create a new bug report with up-to-date information by following this link: https://github.com/nextcloud/server/issues/new?assignees=&labels=bug%2C0.+Needs+triage&template=BUG_REPORT.yml&title=%5BBug%5D%3A+

@szaimen szaimen added needs info 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 1. to develop Accepted and waiting to be taken care of labels Jan 23, 2023
@szaimen szaimen closed this as completed Mar 6, 2023
@marcelklehr marcelklehr reopened this Apr 26, 2023
@marcelklehr marcelklehr added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of 27-feedback bug feature: comments feature: file sidebar Related to the file sidebar component needs info regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants