Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VerifyUserData job always gets readded #30374

Closed
juliushaertl opened this issue Dec 22, 2021 · 1 comment · Fixed by #30491
Closed

VerifyUserData job always gets readded #30374

juliushaertl opened this issue Dec 22, 2021 · 1 comment · Fixed by #30491

Comments

@juliushaertl
Copy link
Member

juliushaertl commented Dec 22, 2021

In cases the VerifyUserData job fails or terminates immediately (due to no validation being required) the job is instantly readded again due tot he updateAccount logic. It seems that there was some change to fetch the old account data now in an indexed array rather then one with the property names as key. In the following $oldMail will just always be null and the job gets readded:

image

Steps to reproduce:

Expected:

  • There is no job present anymore after the removal

Actual:

  • The job gets added again right away

@blizzz @Pytal As a quick fix i thought about just bringing back the property name array key but I don't feel familiar enough with the code to tell if that is a good idea right away. Maybe you have a better insight there.

Could potentially cause quite some cron delay or unnecessary load on systems with larger user count.

@juliushaertl juliushaertl added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Dec 22, 2021
@Pytal Pytal added 3. to review Waiting for reviews feature: emails feature: users and groups and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jan 5, 2022
@Pytal
Copy link
Member

Pytal commented Jan 5, 2022

Account properties were switched from an associative to indexed array to allow for multiple email addresses #27474

Wasn't able to test this as the job wasn't run on my instance after doing the repro steps so let me know if #30491 fixes it @juliushaertl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants