Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share API returns truncated circleId in share_with value #30458

Closed
jmptbl opened this issue Dec 31, 2021 · 3 comments · Fixed by #30475
Closed

Share API returns truncated circleId in share_with value #30458

jmptbl opened this issue Dec 31, 2021 · 3 comments · Fixed by #30475
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug needs info

Comments

@jmptbl
Copy link
Contributor

jmptbl commented Dec 31, 2021

I hope the brevity of this report can be forgiven - it's a really simple bug fix.

The Share API is returning a truncated circleId in share_with in share elements of IShare::TYPE_CIRCLE. Example API outputs below.

Nextcloud 22.2.3
PHP 8.0.13

Never upgraded, fresh install.

Attached patch fixes it for me: share-api-circleid.txt

Share element from the Share API showing the truncation in share_with: share-api-example.txt

The Circle element in share_with above, but from the Circle API: circle-api-example.txt

@jmptbl jmptbl added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Dec 31, 2021
@solracsf

This comment has been minimized.

@jmptbl

This comment has been minimized.

@szaimen
Copy link
Contributor

szaimen commented Jan 23, 2023

Hi, please update to 24.0.9 or better 25.0.3 and report back if it fixes the issue. Thank you!

My goal is to add a label like e.g. 25-feedback to this ticket of an up-to-date major Nextcloud version where the bug could be reproduced. However this is not going to work without your help. So thanks for all your effort!

If you don't manage to reproduce the issue in time and the issue gets closed but you can reproduce the issue afterwards, feel free to create a new bug report with up-to-date information by following this link: https://github.com/nextcloud/server/issues/new?assignees=&labels=bug%2C0.+Needs+triage&template=BUG_REPORT.yml&title=%5BBug%5D%3A+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug needs info
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants