Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload/add button style and discoverability #37207

Closed
jancborchardt opened this issue Mar 14, 2023 · 10 comments · Fixed by #39884
Closed

Upload/add button style and discoverability #37207

jancborchardt opened this issue Mar 14, 2023 · 10 comments · Fixed by #39884
Assignees
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement

Comments

@jancborchardt
Copy link
Member

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
The upload button in Files is not super present, and looks old compared to our other buttons.

Describe the solution you'd like
We should upgrade it to the secondary NcButton from the components. And a simple text "Add" next to the "+" in the upload button would be good.

Additional context
Current:
image

Proposed:
image

@jancborchardt jancborchardt added enhancement design Design, UI, UX, etc. 1. to develop Accepted and waiting to be taken care of labels Mar 14, 2023
@ishaan730

This comment was marked as off-topic.

@jancborchardt

This comment was marked as off-topic.

@ishaan730

This comment was marked as off-topic.

@lhsazevedo
Copy link
Contributor

lhsazevedo commented Apr 30, 2023

Hi! Would be a reasonable approach to proceed with the original task and move @ishaan730's great proposal to a new issue?
That way we can improve the product for users right away, while the proposal is matured and discussed with the attention it deserves.

EDIT:
@jancborchardt I see that this part of the files app wasn't fully migrated to Vue just yet. Should we wait for it?

@jancborchardt
Copy link
Member Author

@lhsazevedo yes, absolutely the original proposal still stands and makes sense as it is a very small but nice improvement. If you like, feel free to submit a pull request for it. :)

@jancborchardt
Copy link
Member Author

@szaimen would be nice to have this in both Files and the new filepicker by @susnux for 27.1.0. :)

@susnux
Copy link
Contributor

susnux commented Aug 15, 2023

Filepicker PR: nextcloud-libraries/nextcloud-dialogs#892

@theosche
Copy link

Looks good on Safari 16.5.1:
Capture d’écran 2023-09-18 à 22 23 50
But not that good on Firefox 116.0.2:
Capture d’écran 2023-09-18 à 22 23 33
[Nextcloud 27.1.0]
Should I open another issue ?

@szaimen
Copy link
Contributor

szaimen commented Sep 18, 2023

You need to clear the browser cache...

@theosche
Copy link

You need to clear the browser cache...

Thanks it worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

8 participants