Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV] Files list breadcrumbs contain not valid attributes #41780

Closed
susnux opened this issue Nov 27, 2023 · 0 comments · Fixed by #41808
Closed

[BITV] Files list breadcrumbs contain not valid attributes #41780

susnux opened this issue Nov 27, 2023 · 0 comments · Fixed by #41808
Assignees
@emoral435
Labels
2. developing Work in progress 28-feedback accessibility bug feature: files
Milestone
Nextcloud 29

Comments

@susnux
Copy link
Contributor

susnux commented Nov 27, 2023

The breadcrumbs of the file list contain a dir attribute on the li element.
But the dir attribute is meant for text direction and might only have the values ltr rtl or auto.

This is an accessibility issue as the attribute probably should be either a data-dir attribute or is a vue property not correctly set.
@susnux susnux added this to the Nextcloud 29 milestone Nov 27, 2023
@emoral435 emoral435 self-assigned this Nov 28, 2023
@emoral435 emoral435 added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Nov 28, 2023
@emoral435 emoral435 mentioned this issue Nov 28, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emoral435 emoral435

Labels
2. developing Work in progress 28-feedback accessibility bug feature: files
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging a pull request may close this issue.

accessibility fix - changed the dir attribute to have valid value nextcloud/server
3 participants
@susnux @szaimen @emoral435