Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV]: Replace entries of action menu for contacts inside of contacts menu #42708

Closed
JuliaKirschenheuter opened this issue Jan 11, 2024 · 2 comments · Fixed by #42713
Closed
Assignees
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility

Comments

@JuliaKirschenheuter
Copy link
Contributor

Currently there are entries with images and text. This images are <img> without any alternative text.

Screenshot from 2024-01-11 14-17-30

Images are not important in this part and we can replace them with NcActionText, like:

<NcActionText>
<template #icon>
	<Icon :size="20" />
</template>
{{ t('...', 'local time') }}
</NcActionText>						
@JuliaKirschenheuter JuliaKirschenheuter added 1. to develop Accepted and waiting to be taken care of accessibility labels Jan 11, 2024
@ChristophWurst
Copy link
Member

We can't change the img to an svg icon here because the data is provided through a stable API:

/**
* @param string $icon absolute URI to an icon
* @since 12.0
*/
public function setIcon(string $icon);

Can the img be marked as decorative?

@ChristophWurst ChristophWurst self-assigned this Jan 11, 2024
@JuliaKirschenheuter
Copy link
Contributor Author

Can the img be marked as decorative?

yes, please add aria-hidden="true" to each <img>

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Jan 11, 2024
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility
Projects
Development

Successfully merging a pull request may close this issue.

3 participants