Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: “new” Upload progress bar in NC 28.0.x not working when files max_chunk_size set to –value=0 #43335

Closed
6 of 8 tasks
chrissi55 opened this issue Feb 4, 2024 · 3 comments · Fixed by nextcloud-libraries/nextcloud-upload#1080
Assignees
Labels
1. to develop Accepted and waiting to be taken care of 28-feedback bug feature: files
Milestone

Comments

@chrissi55
Copy link

chrissi55 commented Feb 4, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

After upgrade my NC from 27.1.6 to 28.0.2.5 i recognize that during any upload via WebUI (tested Firefox ESR 115, vivaldi, brave) that the upload progress bar doesn't show any information nor time elapsed / till completition.
The uploads itself seems to work -> after a couple of time the "empty progress bar" vanish and the uploaded file(s) appear in the destination folder. I opened a thread for that here: https://help.nextcloud.com/t/new-upload-progress-bar-in-nc-28-0-2-not-working-when-chunk-size-set-to-value-0/180797/20

I have to upload files of all size so as larger files e.g. linux images of gigabyte in size. So for a longer period i have set my NC serverside max_chunk_size to the value=0 and that seems to "kill" the new ajax upload progress now in NC 28.x

The admin manual here:
https://docs.nextcloud.com/server/latest/admin_manual/configuration_files/big_file_upload_configuration.html#adjust-chunk-size-on-nextcloud-side

still gives an OK for max_chunk_size --value=0 so i assume it is a bug.

Steps to reproduce

  1. execute sudo -u www-data php occ config:app:set files max_chunk_size --value 0

  2. reboot the server

  3. try to upload files to any destination folder of your nextcloud

  4. see that no progress in upload progress bar is shown (sometimes you can crash the whole browser with that)

  5. set back the max_chunk_size to a value higher than 0

  6. reboot once again and see that the upload progress bar is working as expected but with the fact, that larger file uploads become a waiting game

Expected behavior

the upload progress bar should also work when serverside nextcloud settings have set max_chunk_size to value 0
that worked till nc 27.1.6 and is still part of the admin manual

https://docs.nextcloud.com/server/latest/admin_manual/configuration_files/big_file_upload_configuration.html#adjust-chunk-size-on-nextcloud-side

Installation method

Community Web installer on a VPS or web space

Nextcloud Server version

28

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Nginx

Database engine version

PostgreSQL

Is this bug present after an update or on a fresh install?

Upgraded to a MAJOR version (ex. 22 to 23)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "192.168.55.16",
            "MY.DOMAIN"
        ],
        "dns_pinning": true,
        "activity_expire_days": 14,
        "auth.bruteforce.protection.enabled": true,
        "blacklisted_files": [
            ".htaccess",
            "Thumbs.db",
            "thumbs.db"
        ],
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",
        "overwritehost": "MY.DOMAIN",
        "overwriteconaddr": "^192\\.168\\.55\\.90$",
        "overwriteprotocol": "https",
        "forward_for_headers": [
            "X_FORWARDED_FOR",
            "HTTP_X_FORWARDED_FOR"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "overwrite.cli.url": "https:\/\/MY.DOMAIN",
        "dbtype": "pgsql",
        "version": "28.0.2.5",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "htaccess.RewriteBase": "\/",
        "logtimezone": "Europe\/Berlin",
        "default_phone_region": "DE",
        "logfile": "\/media\/cloud\/data\/nextcloud.log",
        "log_rotate_size": 10485760,
        "cron_log": true,
        "installed": true,
        "filesystem_check_changes": 1,
        "quota_include_external_storage": false,
        "skeletondirectory": "",
        "share_folder": "\/Freigaben",
        "knowledgebaseenabled": false,
        "ldapIgnoreNamingRules": false,
        "ldapProviderFactory": "\\OCA\\User_LDAP\\LDAPProviderFactory",
        "ldapUserCleanupInterval": 20,
        "bulkupload.enabled": false,
        "memcache.local": "\\OC\\Memcache\\APCu",
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "filelocking.enabled": "true",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 0
        },
        "mail_smtpmode": "sendmail",
        "mail_smtpsecure": "ssl",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "465",
        "mail_smtptimeout": 10,
        "mail_smtpauth": 0,
        "mail_smtpauthtype": "LOGIN",
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "maintenance": false,
        "integrity.check.disabled": false,
        "updater.release.channel": "stable",
        "enable_previews": true,
        "preview_Movie_path": "\/usr\/bin\/ffmpeg",
        "preview_ffmpeg_path": "\/usr\/bin\/ffmpeg",
        "enabledPreviewProviders": [
            "OC\\Preview\\PNG",
            "OC\\Preview\\JPEG",
            "OC\\Preview\\GIF",
            "OC\\Preview\\BMP",
            "OC\\Preview\\XBitmap",
            "OC\\Preview\\Movie",
            "OC\\Preview\\PDF",
            "OC\\Preview\\MP3",
            "OC\\Preview\\TXT",
            "OC\\Preview\\MarkDown",
            "OC\\Preview\\HEIC",
            "OC\\Preview\\OpenDocument",
            "OC\\Preview\\MSOffice2003",
            "OC\\Preview\\MSOfficeDoc",
            "OC\\Preview\\Image",
            "OC\\Preview\\Photoshop",
            "OC\\Preview\\SVG",
            "OC\\Preview\\Font",
            "OC\\Preview\\MKV",
            "OC\\Preview\\MP4",
            "OC\\Preview\\AVI",
            "OC\\Preview\\TIFF"
        ],
        "preview_max_x": 2048,
        "preview_max_y": 2048,
        "preview_max_memory": 4096,
        "preview_max_filesize_image": 256,
        "preview_max_scale_factor": 1,
        "trashbin_retention_obligation": "auto, 2",
        "loglevel": 3,
        "mail_sendmailmode": "smtp",
        "data-fingerprint": "FINGERPRINT",
        "onlyoffice": {
            "verify_peer_off": true,
            "jwt_header": "Authorization",
            "jwt_secret": "***REMOVED SENSITIVE VALUE***"
        },
        "encryption.legacy_format_support": false,
        "encryption.key_storage_migrated": false,
        "defaultapp": "dashboard",
        "theme": "",
        "allow_local_remote_servers": true,
        "files_external_allow_create_new_local": true,
        "simpleSignUpLink.shown": false,
        "memories.exiftool": "\/var\/www\/nextcloud\/apps\/memories\/bin-ext\/exiftool-amd64-glibc",
        "memories.vod.path": "\/var\/www\/nextcloud\/apps\/memories\/bin-ext\/go-vod-amd64",
        "memories.vod.ffmpeg": "\/usr\/bin\/ffmpeg",
        "memories.vod.ffprobe": "\/usr\/bin\/ffprobe",
        "memories.gis_type": 2,
        "session_keepalive": true,
        "memories.vod.disable": false,
        "memories.video_default_quality": "-2",
        "maintenance_window_start": 1
    }
}

List of activated Apps

Enabled:
  - activity: 2.20.0
  - admin_audit: 1.18.0
  - bookmarks: 13.1.3
  - bruteforcesettings: 2.8.0
  - calendar: 4.6.4
  - circles: 28.0.0-dev
  - cloud_federation_api: 1.11.0
  - comments: 1.18.0
  - contacts: 5.5.1
  - contactsinteraction: 1.9.0
  - dashboard: 7.8.0
  - dav: 1.29.1
  - federatedfilesharing: 1.18.0
  - federation: 1.18.0
  - files: 2.0.0
  - files_accesscontrol: 1.18.0
  - files_automatedtagging: 1.18.0
  - files_external: 1.20.0
  - files_fulltextsearch: 28.0.0
  - files_pdfviewer: 2.9.0
  - files_reminders: 1.1.0
  - files_sharing: 1.20.0
  - files_trashbin: 1.18.0
  - files_versions: 1.21.0
  - fulltextsearch: 28.0.0
  - fulltextsearch_elasticsearch: 28.0.0
  - gpxpod: 5.0.15
  - groupfolders: 16.0.3
  - logreader: 2.13.0
  - lookup_server_connector: 1.16.0
  - memories: 6.2.2
  - nextcloud_announcements: 1.17.0
  - notes: 4.9.2
  - notifications: 2.16.0
  - notify_push: 0.6.9
  - oauth2: 1.16.3
  - onlyoffice: 9.0.0
  - password_policy: 1.18.0
  - photos: 2.4.0
  - previewgenerator: 5.4.0
  - privacy: 1.12.0
  - provisioning_api: 1.18.0
  - related_resources: 1.3.0
  - serverinfo: 1.18.0
  - settings: 1.10.1
  - sharebymail: 1.18.0
  - support: 1.11.0
  - suspicious_login: 6.0.0
  - systemtags: 1.18.0
  - tasks: 0.15.0
  - text: 3.9.1
  - theming: 2.3.0
  - theming_customcss: 1.15.0
  - twofactor_backupcodes: 1.17.0
  - twofactor_totp: 10.0.0-beta.2
  - twofactor_webauthn: 1.3.2
  - updatenotification: 1.18.0
  - user_ldap: 1.19.0
  - user_status: 1.8.1
  - viewer: 2.2.0
  - weather_status: 1.8.0
  - workflowengine: 2.10.0
Disabled:
  - encryption: 2.16.0 (installed 2.3.0)
  - files_fulltextsearch_tesseract: 27.0.0 (installed 27.0.0)
  - firstrunwizard: 2.17.0 (installed 2.3.0)
  - recommendations: 2.0.0 (installed 1.3.0)
  - survey_client: 1.16.0 (installed 1.2.0)

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

No log entries concerning uploads

Additional info

more info of other users who had a look at similar problems are posted here

https://help.nextcloud.com/t/new-upload-progress-bar-in-nc-28-0-2-not-working-when-chunk-size-set-to-value-0/180797/11

@chrissi55 chrissi55 added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Feb 4, 2024
@susnux susnux self-assigned this Feb 4, 2024
@susnux susnux added 1. to develop Accepted and waiting to be taken care of feature: files and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Feb 4, 2024
@susnux susnux added this to the Nextcloud 29 milestone Feb 4, 2024
@susnux
Copy link
Contributor

susnux commented Feb 4, 2024

This happens because for non chunked uploads we do not update the progress - except when it is finished. I will work on a fix.

@chrissi55
Copy link
Author

chrissi55 commented Feb 6, 2024

can somebody help me how to apply the fix / patch?

@skjnldsv
Copy link
Member

skjnldsv commented Feb 6, 2024

There is no patch, you'll have to wait for the next update :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of 28-feedback bug feature: files
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants