Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sharing email information #4334

Open
MorrisJobke opened this issue Apr 12, 2017 · 9 comments
Open

Improve sharing email information #4334

MorrisJobke opened this issue Apr 12, 2017 · 9 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: sharing

Comments

@MorrisJobke
Copy link
Member

Mockup by @Espina2:

shared folder

cc @nextcloud/designers @nextcloud/sharing

@MorrisJobke MorrisJobke added the 1. to develop Accepted and waiting to be taken care of label Apr 12, 2017
@schiessle
Copy link
Member

Looks nice, for "add to your cloud" we would probably need a new endpoint which first initiate the federated share and then redirect you to your Nextcloud

@rullzer
Copy link
Member

rullzer commented Apr 12, 2017

I would leave out the 'Add to your cloud' as it requires some manual stuff anyway. Either you open a page (with fancy new endpoint) where you enter your own cloud url. Or you just open the link page where you can already do all that.

Since there is no way to directly open your cloud.

But it looks awesome!

@Espina2
Copy link
Contributor

Espina2 commented Apr 12, 2017

If its not possible to do, just remove the button and center the other. :)

@enoch85
Copy link
Member

enoch85 commented Apr 12, 2017

Since there is no way to directly open your cloud.

If you get a share with public link and are using Nextcloud then it's possible. At least from the public link perspective. But I guess you should use federated sharing for that kind of shares...

@rullzer
Copy link
Member

rullzer commented Apr 13, 2017

@enoch85 nope there is not. Because you get the e-mail not from your cloud but from a different cloud. That cloud has no idea if you have your own Nextcloud and if so where it is located.

But anyways. Also huge improvement if we get rid of the extra button ;)

@enoch85
Copy link
Member

enoch85 commented Apr 13, 2017

@rullzer OK, thought error on my end. :)

What I meant was this anyway:

deepinscreenshot20170413080509

@jancborchardt
Copy link
Member

Just a few details:

  • I would cut the sentence between the folder and the buttons since it simply repeats all the information of the header text and the rest of what is visible.
  • Also, the comma between »Hello« and the name is not necessary.
  • In the footer, let’s please not use this »oOo« butchering of the logo ;)

Nice design @Espina2! :)

@enoch85
Copy link
Member

enoch85 commented Jul 11, 2017

Should we improve it even more or can this be closed?

@szaimen

This comment has been minimized.

@szaimen szaimen closed this as completed May 21, 2021
@enoch85 enoch85 reopened this May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: sharing
Projects
None yet
Development

No branches or pull requests

9 participants