Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Drive: new security protection #5815

Closed
MrKrabat opened this issue Jul 20, 2017 · 11 comments
Closed

Google Drive: new security protection #5815

MrKrabat opened this issue Jul 20, 2017 · 11 comments

Comments

@MrKrabat
Copy link

Hello,

Google has changed their security to protect users against 'unverified apps'.
https://gsuite-developers.googleblog.com/2017/07/new-security-protections-to-reduce-risk.html

The problem is, every user who is using Google Drive in Nextcloud is creating an 'unverified app'.
https://docs.nextcloud.com/server/12/admin_manual/configuration_files/external_storage/google.html
When you create a new project it is already under this new rules and you can't connect your account (1).

As described in the article this feature will be soon affecting already existing projects and the whole Google Drive integration will stop working in Nextcloud.

The main problem about this is, that a normal user is not able to verify this app since you need to proof that you control the domain and a lot more. Which means a normal user can't use Google Drive in the future.

Greetings,
MrKrabat

(1) It is possible to allow unverified apps with joining this Google Group https://groups.google.com/forum/#!forum/risky-access-by-unreviewed-apps
It's obviously dangerous for your account. Currently it is possible to leave the group after connecting GDrive with Nextcloud.

@rullzer
Copy link
Member

rullzer commented Jul 22, 2017

mmm so that would probably mean that we should rip out google drive of files_external...

@MorrisJobke
Copy link
Member

mmm so that would probably mean that we should rip out google drive of files_external...

Once we do this following tickets will be obsolete too: #99, #4028, #5748,

@yan12125
Copy link
Contributor

Please don't remove Google Drive functionality. It's still useful for G Suite users. From https://support.google.com/code/contact/oauth_app_verification:

Apps that are going to be used only by users within your G Suite organization
You should not be seeing the unverified app screen. See this FAQ for more details.

I've just set up Google Drive in my Nextcloud instance, and it doesn't show the unverified app consent screen.

@MrKrabat
Copy link
Author

MrKrabat commented Sep 21, 2017

The screen actually looks like this:
nextcloud
If you press the link at the bottom, google will allow you to proceed but opens an input box and want that you enter "Weiter" (german for continue) to confirm.
(like in the gif-animation in the google blog entry)

This new "feature" still exists, but this input box is a nicer way to skip this.

@gvmura
Copy link
Contributor

gvmura commented Oct 9, 2017

@MorrisJobke: Once we do this following tickets will be obsolete too: #99, #4028, #5748,

I don't hope so

@MorrisJobke
Copy link
Member

@icewind1991 Mind to do the same app for Google drive as for Dropbox?

@simon-zumbrunnen
Copy link

The main problem about this is, that a normal user is not able to verify this app since you need to proof that you control the domain and a lot more. Which means a normal user can't use Google Drive in the future.

In my opinion, the user shouldn't have to care about the app credentials anyways. An admin should create an app, go through the verification process, configure the app credentials globaly for all users. (see #2861) Then the user only has to allow this app access to his account to use this feature.

@ferdiga
Copy link

ferdiga commented Jan 25, 2018

I have turned the "allow unsafe apps" feature off and on again and get the infamous
Google_Auth_Exception: Error refreshing the OAuth2 token, message: '{ "error" : "invalid_grant" }'.
message.
it seems to me that the refresh token is out of date.
https://stackoverflow.com/questions/35878859/google-oauth2-error-refreshing-the-oauth2-token-message-error-invalid
how can I update the refresh token in nextcoud???

@mursec
Copy link

mursec commented Apr 6, 2018

What can I do to help keep Google Drive on the external storage list?

@LawnSounds
Copy link

Cyberduck can connect with Google Drive locally with some Google App. Could this be implemented? Is this the correct place to post this?

@nextcloud-bot nextcloud-bot added the stale Ticket or PR with no recent activity label Jun 20, 2018
@MorrisJobke
Copy link
Member

As this is a separate app: please report it in that repo https://github.com/NastuzziSamy/files_external_gdrive/

@nextcloud-bot nextcloud-bot removed the stale Ticket or PR with no recent activity label Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants