The loading icon is not at the same position as the checkbox it replaces

[danxuliu]

In the Sharing tab of the details view of the Files app when a checkbox is clicked it is replaced by a working/loading icon while the operation is being processed in the server. However, the icon is not placed exactly at the same position as the checkbox it replaces.

In the screenshots below it is subtle, but it can be clearly noticed when clicking on the checkbox, as when the icon is shown the text next to it is moved (in the first case to the left, in the second case to the right).

Share link:

Allow editing:

I have noticed this in the Sharing tab, although I do not know if this technique of replacing the checkbox with the icon is used anywhere else (although in my opinion it should be, as it shows that the operation is in process while also ensuring that the user will not mess with it by clicking again on the checkbox before it has finished ;-) ).

@nextcloud/designers

[MorrisJobke]

It's fine to fix this in 14 and maybe backport to stable13.

[skjnldsv]

@MorrisJobke backporting isn't really necessary, this doesn't break the uid nor the ux!

[soumyanjaleemahapatra]

Can I take over this issue?

[skjnldsv]

@soumyanjaleemahapatra go ahead ! :)

[AasthaGupta]

@soumyanjaleemahapatra are you still working on this or can I take this up?

[skjnldsv]

If one of you is taking over this issue, please fix this in a global way. So that every checkbox using the icon-loading-small class has the same design. Do not fix only the sharing sidebar checkboxes :)

[soumyanjaleemahapatra]

@AasthaGupta Please take over the issue if you can. Thanks!

[MorrisJobke]

Fixed by the migration to the dropdown:

#10218