-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Federated typing indicators with same userId #12802
Comments
You should rely on the |
Yes, but if I have a session on web and one on iOS, currently when I type on web, I don’t show myself as typing in iOS. But this is not possible with the session id ? |
Besides, message are never sent back to the own session: |
Oh, I see, that's right. So what I could do is add a flag in the |
Yes, having a |
We might need the information for other parts in the future, too. Also I would rather have it only once in the |
Just to be sure (I don't know right now on the top of my head), when I join a room where participants are already there, do I still receive a join for those that are already part of the conversation? And there's no chance that a typing message would be received before I receive a join message, right? I guess then it would work as well and we can just map the session. |
You will receive join events for all sessions already in the room. As they are sent asynchronously (especially in clustered setups), there is a small chance that a typing message could be sent while these join events are being sent. How do you get the display name to show with the typing status? Don't you use the session id to lookup the entry from the join events already? |
Flag added in strukturag/nextcloud-spreed-signaling@fc0591b |
That is a very good point indeed 😂 Yes, then this would be absolutely fine. Thanks! |
This comment was marked as off-topic.
This comment was marked as off-topic.
Is there still something to do here? |
The flag was added and the handling was implemented on iOS. In theory frontend needs to also handle this, but might not be worth the effort. |
Since it's not directly related to federated calls, I thought creating a new issue makes the most sense.
While testing #12604 I was unable to get typing indicators to work at first. For my testing I used the same userId on both servers, so I basically had 2 admins in my conversation:
Since we suppress typing indicators for ourselves, the federated indicator did not show up, but the signaling messages from that user were received fine.
Purely from the signaling message, I don't see a way to distinguish if it's "my" userId or a federated one:
The text was updated successfully, but these errors were encountered: