fix(Quote): prevent button click event from propagation #12824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
added
3. to review
bug
feature: frontend 🖌️
|
/backport to stable29 |
ShGKme
approved these changes
Jul 26, 2024
we have that only in one place, and Quote is used there only as a visual element, so, could be altered with |
Antreesy
force-pushed
the
fix/noid/quote-abort-stop-propagation
branch
from
631980e
to
605ba82
Compare
ShGKme
reviewed
Jul 27, 2024
- button was wrapped in a <a> link, which was an a11y issue and false positive trigger when cancelling the reply - for 'reply to message' variant wrap component in a simple div Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
fix/noid/quote-abort-stop-propagation
branch
from
605ba82
to
5a3d732
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
<a>link, so bubbling click event doesn't get captured by router-link, and causes watning dialog to be shown (my humble assumption)🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist