-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly handle linked files with direct editing #1170
Comments
On web ui one is then simply redirected, right? Regarding adding file link: |
Yes, but on the web UI we have an authenticated session, while the direct editing uses a one-time token just for the file. Therefore we can only redirect to the normal files app, which might require the user to log in again. |
Hm. So we have three new interface methods:
|
In addition we would also need those two for inserting links to any file type:
|
This comment has been minimized.
This comment has been minimized.
Related to: #1169 In 1169 I suggest we handle the opening in the browser, as this would also work for direct editing from desktop. But we could additionally send a PostMessage to the clients in case they can handle the open request more gracefully. |
Yep, sounds like something for a |
ToDo
Currently we have no special handling for linking files with direct editing, so this is not working as described in nextcloud/android#7192.
I currently see two ways of implementing support for opening linked files:
In addition there is also no support for adding file links through direct editing, since the user is not authenticated via a session. To solve this we'd need to implement something similar to the Collabora insert image functionality where a postMessage is emitted by the text app. Then the mobile clients would show a file picker and pass the selected file to the webview again.
cc @tobiasKaminsky @marinofaggiana What do you think. Does that make sense?
The text was updated successfully, but these errors were encountered: