Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨📱 Text app review: Mobile focus #2211

Closed
17 of 18 tasks
jancborchardt opened this issue Mar 1, 2022 · 6 comments
Closed
17 of 18 tasks

✨📱 Text app review: Mobile focus #2211

jancborchardt opened this issue Mar 1, 2022 · 6 comments
Labels
2. developing design Experience, interaction, interface, … enhancement New feature or request
Milestone

Comments

@jancborchardt
Copy link
Member

jancborchardt commented Mar 1, 2022

(Notes from first review on 2020-10-06 in issue at #1075 )

Header bar #2440 #2441

  • Make backgound solid var(--color-main-background)
  • Add small blue flavor bar on the top like in Nextcloud Office
  • Bold the filename / title

Toolbar

Collaborators #2449 #2450

  • "Saved" text is too wide
    • Could be combined with participants, showing a circle indicator on unsaved changes, and in the participants menu we can show extra text for "Last saved x minutes ago" on top of the participant list → let’s do this one
      • Adjust behavior on desktop, but keep "Saved" text as additional info
    • Could collapse into a checkmark icon on mobile, could even be actionable to save
    • Could show asterisk next to filename, but filename is not present on mobile
    • Could be in a subline below the title, but filename is not present on mobile
  • People avatars could be a bit smaller → from 44px to e.g. 36px
  • Avatars should move a bit closer together to save space
  • Author color borders could be var(--color-main-background) when author colors are not enabled so there is separation, and when author colors are not enabled the colors don’t make sense yet anyway.
  • Always show all participants in dropdown (including yourself so you know your own color)

Content

  • If possible, cursor of other collaborators could show (there is a tiptap component) Editing cursor #90
@jancborchardt jancborchardt added the enhancement New feature or request label Mar 1, 2022
@jancborchardt jancborchardt added the design Experience, interaction, interface, … label Mar 1, 2022
@juliushaertl
Copy link
Member

@jancborchardt If I remembered correctly we also talked about getting rid of the menu bubble for links and move that to the menu bar, right? Then I'll add that as well

@juliushaertl juliushaertl removed their assignment Mar 24, 2022
@juliushaertl juliushaertl added this to the Nextcloud 24 milestone Mar 24, 2022
@juliushaertl
Copy link
Member

@nextcloud/office Adding this to the 24 milestone, feel free to pick some low hanging fruits for some polishing during the beta phase.

@szaimen
Copy link
Contributor

szaimen commented Mar 24, 2022

Maybe this should be added to the list as well?
#2203

@luka-nextcloud
Copy link
Contributor

@jancborchardt @juliushaertl
Author color borders could be var(--color-main-background) when author colors are not enabled so there is separation, and when author colors are not enabled the colors don’t make sense yet anyway.
If colors are not enabled, we still need a way to distinguish ownership, and we can do it by giving border color.
Is that correct?

@luka-nextcloud
Copy link
Contributor

@jancborchardt
Author color borders could be var(--color-main-background) when author colors are not enabled so there is separation, and when author colors are not enabled the colors don’t make sense yet anyway.

Do we want to always show author border?
If enabled -> border color = author color
If not enabled -> border color = var(--color-main-background)

@juliushaertl
Copy link
Member

Closing as remaining points have separate tickets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing design Experience, interaction, interface, … enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

4 participants