Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize full screen mode for viewer integrations #1252

Open
juliushaertl opened this issue May 17, 2022 · 1 comment
Open

Standardize full screen mode for viewer integrations #1252

juliushaertl opened this issue May 17, 2022 · 1 comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request

Comments

@juliushaertl
Copy link
Member

Collabora and Text use a bit of a hacky approach to make the viewer show their content full screen with the special case that for Collabora the viewer header is actually hidden and the close/sidebar buttons are actually rendered by Collabora.

With #1229 that basically caused some regressions on the Text and Collabora side. To avoid that it would be good to have some indicator on the apps viewer integration that the modal content should span full width and height.

This could be handled similarly to #1051 to be an additional option on the handler registration.

Any objections @skjnldsv ?

@juliushaertl juliushaertl added enhancement New feature or request 0. Needs triage Pending approval or rejection. This issue is pending approval. labels May 17, 2022
@skjnldsv
Copy link
Member

skjnldsv commented Jun 3, 2022

Collabora and Text use a bit of a hacky approach to make the viewer show their content full screen with the special case that for Collabora the viewer header is actually hidden and the close/sidebar buttons are actually rendered by Collabora.

With #1229 that basically caused some regressions on the Text and Collabora side. To avoid that it would be good to have some indicator on the apps viewer integration that the modal content should span full width and height.

This could be handled similarly to #1051 to be an additional option on the handler registration.

Any objections @skjnldsv ?

None, pdf viewer would also love this :)

@juliushaertl juliushaertl added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request
Projects
Status: 📄 To do (~10 entries)
Development

No branches or pull requests

2 participants