Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hide download action when file does not provide download permissions #2482

Merged
merged 4 commits into from
Sep 15, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Sep 8, 2024

This is not only a possibility for public shares but also for internal shares, the current code only "checked" public shares.

This adds the same logic we use in the files app. Probably something to move to @nextcloud/sharing but for the moment lets just reuse here.

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews labels Sep 8, 2024
@susnux susnux added this to the Nextcloud 31 milestone Sep 8, 2024
@susnux
Copy link
Contributor Author

susnux commented Sep 8, 2024

/backport to stable30

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Sep 8, 2024
@susnux susnux force-pushed the fix/hide-download-correctly branch 2 times, most recently from eb9465a to b6722ac Compare September 8, 2024 20:08
…ions

This is not only a possibility for public shares but also for internal shares,
the current code only "checked" public shares.
This adds the same logic we use in the files app. Probably something to move to
`@nextcloud/sharing` but for the moment lets just reuse here.

Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv force-pushed the fix/hide-download-correctly branch 2 times, most recently from 8f0dfcc to 4263b72 Compare September 15, 2024 09:27
@skjnldsv
Copy link
Member

/compile amend /

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv merged commit cc16fbc into master Sep 15, 2024
28 checks passed
@skjnldsv skjnldsv deleted the fix/hide-download-correctly branch September 15, 2024 10:56
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants