fix: Make loading the viewer an init script #2486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
commented
Sep 9, 2024
| @@ -4,7 +4,7 @@ | |||
| "optimize-autoloader": true, | |||
| "classmap-authoritative": true, | |||
| "platform": { | |||
| "php": "8.0" | |||
| "php": "8.1" | |||
There was a problem hiding this comment.
otherwise nextcloud/ocp stays at some very old version due to other dependencies that could not be updated.
Meaning this is required to update a version that known addInitScript...
|
/compile |
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/load-viewer-init
branch
from
d3a822f
to
d71d305
Compare
|
@susnux Do you think it would make sense to also backport this for nextcloud/richdocuments#3815 ? I would imagine this also helps there. |
|
@juliushaertl yes this makes sense, but this does not work with Nextcloud 30 and before on public shares. As for those versions the legacy file actions need to be registered after the file list. |
|
/backport to stable30 |
3 tasks
|
/backport to stable29 |
|
/backport to stable28 |
3 tasks
backportbot
bot
removed
the
backport-request
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all init logic into an init script so that the viewer action is always registered before the file list is loaded.