fix: make dark header configurable #2528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejo-
added
regression
2 tasks
|
nextcloud/text#6404 contains screenshots of what this fixes. |
mejo-
force-pushed
the
fix/configurable_header_dark
branch
from
c732f45
to
b3a4444
Compare
|
/backport to stable30 |
mejo-
force-pushed
the
fix/configurable_header_dark
branch
2 times, most recently
from
2da2de3
to
2270487
Compare
|
Ready for review. |
mejo-
force-pushed
the
fix/configurable_header_dark
branch
from
2270487
to
57be472
Compare
Required to fix regression with Text in Viewer in Nextcloud 30, where we still want a white viewer header. Also fixes the header color for PDFs with light theme. Fixes: nextcloud/text#6386 Co-authored-by: Jonas <[email protected]> Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/configurable_header_dark
branch
from
57be472
to
71dcbfa
Compare
susnux
approved these changes
Sep 17, 2024
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
backportbot
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required to fix regression with Text in Viewer in Nextcloud 30, where we still want a white viewer header.
Requires nextcloud-libraries/nextcloud-vue#6083